You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
The code logic here is unnecessarily detached from the rest of the VM tester code base and round-trips on changing something here, testing the efforts and then have this working with the VM test runner are extremely and unnecessarily long. Just hanging on this again while examining some failures on older blockchain tests.
I propose that we just move the code logic from here to the VM test runner code base and keep this repository only for updating the submodule respectively keeping the large ethereum/tests submodule code base out of the monorepo.
Then we can easily improve on the code base respectively adopt to our needs, also x-checks while working with the tests if tests are loaded correctly (especially important due to relatively frequent and partly implicit changes on the ethereum/tests folder structure. With keeping the procedure on doing tagged releases here and link to them from the VM package this should be also unproblematic from a stability PoV.
Found this such a nobrainer on a second thought and would want to use this for the blockchain test fixes, so I directly executed on this - see ethereumjs/ethereumjs-monorepo#808 - hope that this was not prematurely.
Just a reminder that ethereumjs-txalso uses this package. Should it prevent us from moving code directly to the VM, I could work on some ways to help local package development. Something like:
npm run link:package ethereumjs-testing ../../ejs-testing
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The code logic here is unnecessarily detached from the rest of the VM tester code base and round-trips on changing something here, testing the efforts and then have this working with the VM test runner are extremely and unnecessarily long. Just hanging on this again while examining some failures on older blockchain tests.
I propose that we just move the code logic from here to the VM test runner code base and keep this repository only for updating the submodule respectively keeping the large
ethereum/tests
submodule code base out of the monorepo.Then we can easily improve on the code base respectively adopt to our needs, also x-checks while working with the tests if tests are loaded correctly (especially important due to relatively frequent and partly implicit changes on the
ethereum/tests
folder structure. With keeping the procedure on doing tagged releases here and link to them from the VM package this should be also unproblematic from a stability PoV.//cc @evertonfraga
The text was updated successfully, but these errors were encountered: