Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

missing resetting timers in the http handlers #1045

Closed
nonsense opened this issue Dec 4, 2018 · 0 comments · Fixed by ethereum/go-ethereum#18249
Closed

missing resetting timers in the http handlers #1045

nonsense opened this issue Dec 4, 2018 · 0 comments · Fixed by ethereum/go-ethereum#18249
Labels

Comments

@nonsense
Copy link
Contributor

nonsense commented Dec 4, 2018

We used to have http.request.$method.time resetting timers in every handler, but they seem to be gone.

We should add them back to the codebase, similar to:

	defer metrics.GetOrRegisterResettingTimer(fmt.Sprintf("peer.sendpriority_t.%d", priority), nil).UpdateSince(time.Now())

cc @justelad

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant