Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove useless input style property #75

Merged
merged 4 commits into from
Mar 18, 2021

Conversation

whitestranger7
Copy link
Member

remove unnecessary styles

Copy link
Member

@artyorsh artyorsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the final look of the component configured with caption or captionIcon props. Since we don't use this default spacing between caption text and Input field, a user will more likely have to apply it on his own. Which makes Eva not Eva.

Instead, I would suggest removing the captionIcon property and wrap the entire caption element in FalsyFC or better FalsyText so we can remove the caption container view. This way of composing elements will allow us reducing useless spacings between components.

@whitestranger7 whitestranger7 marked this pull request as draft March 16, 2021 15:26
@whitestranger7 whitestranger7 marked this pull request as ready for review March 16, 2021 16:37
@malashkevich malashkevich merged commit 1cf6e51 into eva-design:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants