chore(build): Run semantic release on latest node #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the build on Node 6, we only have NPM 3, which doesn't have `npx`. So by adding the deploy `on` filter to run `semantic-release` on the latest node version, we won't try to even run it on Node 6. BREAKING CHANGE: We need to trigger a version bump after taking over the package
|
buuuuuuut how was this working before?? |
|
It hasn't yet |
rwholey-eb
approved these changes
Jun 22, 2018
|
yep! and won't know about this one until it merges and we see! 🤞 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running the build on Node 6, we only have NPM 3, which doesn't have
npx. So by adding the deployonfilter to runsemantic-releaseon the latest node version, we won't try to even run it on Node 6.BREAKING CHANGE: We need to trigger a version bump after taking over the package. Because #33 was just a
chore(),semantic-releaseassumed there was nothing to release.How Has This Been Tested?
Unfortunately cannot test w/o releasing 😔
Screenshots (if appropriate):
n/a
Checklist:
yarn validateto ensure that tests, typescript and linting are all in order.