fix(request): Set GET as default request method #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwelch-eb
reviewed
Dec 11, 2018
| @@ -37,7 +37,7 @@ const _tryParseJSON = (res: Response): Promise<any> => { | |||
| */ | |||
| export const _fetchJSON = ( | |||
| url: string, | |||
| {headers, method, mode, ...options}: RequestInit = {} | |||
| {headers = {}, method = 'GET', mode, ...options}: RequestInit = {} | |||
There was a problem hiding this comment.
Another way to accomplish this would be to update the if below to match how we do it internally.
if (method && method !== 'GET') {
There was a problem hiding this comment.
Probably should go with the other way. Otherwise a lot of internal code would break.
There was a problem hiding this comment.
Internally, we also default it, but we do it later in this function. I would imagine the internal function was written pre-es6 defaults
jcreamer898
approved these changes
Dec 11, 2018
|
Are we good to merge this? |
benmvp
approved these changes
Dec 24, 2018
|
Sounds good I will bump in core in the AM. |
|
🎉 This PR is included in version 1.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #49, query params were being ignored when passed in via the SDK.
I investigated and found that this was due to our default of the
Content-Typeheader. The defaulting was put in place to handlePOSTbut since method is undefined it was also being set for impliedGETrequests.How Has This Been Tested?
Tests have been updated. I also verified that setting get will address query params not being parsed properly on the backend.
Screenshots (if appropriate):
Checklist:
yarn validateto ensure that tests, typescript and linting are all in order.resolves #49