Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add organizations api #54

Merged
merged 6 commits into from
Jan 29, 2019
Merged

Conversation

kwelch
Copy link
Contributor

@kwelch kwelch commented Jan 23, 2019

Description

Adds helper methods for making calls to the organizations api.

Currently this only adds the get organizations by user id call.

How Has This Been Tested?

Tests have been added to cover the new API call.

Screenshots (if appropriate):

Checklist:

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have run yarn validate to ensure that tests, typescript and linting are all in order.

Copy link

@jonathancreamer-eb jonathancreamer-eb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny comment which is only relevant if you wanna try to use the typedoc thing I mentioned in my other PR.

* API for working with Organizations
*/
export class OrganizationsApi extends BaseApi<PaginatedResponse<Organization>> {
getByUser(userId: string) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems silly, but maybe add some docs to each method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc update pushed

@kwelch-eb kwelch-eb merged commit d99fd28 into eventbrite:master Jan 29, 2019
@ebtravis
Copy link
Collaborator

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kwelch kwelch deleted the add-organizations-api branch January 29, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants