Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: optimizations #2

Closed
simon-weber opened this issue Aug 4, 2015 · 1 comment
Closed

RFC: optimizations #2

simon-weber opened this issue Aug 4, 2015 · 1 comment

Comments

@simon-weber
Copy link

I've been playing around with setting up knows at Venmo. One of the blockers was speed: knows more than doubled our build time.

I took at stab at optimizing it and managed to reduce the overhead by ~80%, albeit with some breaking changes. The biggest win, though - switching to setprofile - should be backwards compatible (I think, at least; I didn't test it with multiple threads).

I figured I'd open an issue rather than a PR to get your thoughts on what you'd be interested in merging. Here are the changes: master...venmo:sw_optimize.

@eyalr
Copy link
Contributor

eyalr commented Aug 5, 2015

One of the directions I was considering going with this was specificity. Currently, it does a mapping of file => tests, but in the future the current methodology could theoretically support a line_in_file => tests. I think that there's definitely room for a --quick flag, perhaps? Overall this looks great though, please issue a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants