Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CodeBuildWaiter #267

Closed
ckunki opened this issue Mar 28, 2024 · 0 comments · Fixed by #268
Closed

Refactor CodeBuildWaiter #267

ckunki opened this issue Mar 28, 2024 · 0 comments · Fixed by #268
Assignees
@ckunki
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Mar 28, 2024

Currently, timings only can be specified in terms of seconds.
Proposal: Use tenacity and benefit from support for arbitrary timedelta expressions.
@ckunki ckunki self-assigned this Mar 28, 2024
@ckunki ckunki added the refactoring Code improvement without behavior change label Mar 28, 2024
@ckunki ckunki mentioned this issue Apr 2, 2024
Merged
ckunki added a commit that referenced this issue Apr 4, 2024
@ckunki @tkilias
Refactoring/#267 switch codebuild waiter to tenacity (#268)
767c36f 
* Switched CodeBuildWaiter to use tenacity
* Link README to user guide version 2.0.0
* Make failed unit tests stop running integration or notebook-tests
* Moved codebuild waiter tests to unit tests

Co-authored-by: Torsten Kilias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckunki ckunki

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring/#267 switch codebuild waiter to tenacity exasol/ai-lab
1 participant
@ckunki