Re-enable disabled notebook tests #318
Assignees
Labels
refactoring
Code improvement without behavior change
Comments
This was referenced Aug 22, 2024
|
Please enable tests for cloud storage notebook by renaming the file disabled_nbtest_cloud.py. |
tkilias
added a commit
that referenced
this issue
Aug 25, 2024
…tests, move ibis notebook to new download URL, (#319) * #308: Updated Dependencies of Jupyter Environment and pyproject.toml * #298: Fixed vulnerabilities * #322: Made URL in IBIS notebook point to a new example data bucket * #318: Re-enabled tests for cloud storage notebook * Updated version constraint for stopwatch * Replaced GitHub dependency in file test_dependencies.txt for notebook tests by PyPI dependency. * Fixed CloudFormation lint tests * Fixed name of docker registry in integration test to satisfy legal names for docker registries. * Updated changes file * Changed version to 3.0.0 * Fixed cloud storage notebook test * Fixed cloud_store_config.ipynb temporarily by correctly reimplement bfs_utils.put_file --------- Co-authored-by: Torsten Kilias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
Latest version of notebook-connector is known to cause failures.
Still, the latest PR in the AI-Lab could be merged.
This was only possible because the tests for some of the notebooks had been disabled.
Additionally, different methods have been used to disable the notebook tests:
@pytest.mark.skipSee also issues
Overview of Requested Changes and Future Steps
The current ticket requests to
As currently, some of the tests are expected to fail, while we still want to enable merging other PRs to main, the current ticket requests to create a separate branch.
Only after fixing all tests, the separate branch is planned to be merged to main.
Acceptance Criteria
refactoring/#318-Enable-all-notebook-testsnbtest_cloud.py@pytest.mark.skip@pytest.mark.skipThe text was updated successfully, but these errors were encountered: