#37: Fixed review findings.

exasol · Oct 11, 2021 · fdcb543 · fdcb543
1 parent 5765936
commit fdcb543
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/pom.xml b/pom.xml
@@ -104,7 +104,7 @@
             <version>0.4.0</version>
         </dependency>
         <dependency>
-            <!-- override testconatainers dependency to fix github release (https://github.com/exasol/exasol-testcontainers/issues/122)-->
+            <!-- override testcontainers dependency to fix GitHub release (https://github.com/exasol/exasol-testcontainers/issues/122)-->
             <groupId>org.testcontainers</groupId>
             <artifactId>testcontainers</artifactId>
             <version>1.16.0</version>
@@ -365,7 +365,7 @@
             <plugin>
                 <groupId>com.exasol</groupId>
                 <artifactId>error-code-crawler-maven-plugin</artifactId>
-                <version>0.6.0</version>
+                <version>0.7.0</version>
                 <executions>
                     <execution>
                         <goals>

diff --git a/src/main/java/com/exasol/matcher/UpcastOnlyCellMatcher.java b/src/main/java/com/exasol/matcher/UpcastOnlyCellMatcher.java
@@ -32,13 +32,12 @@ public boolean matches(final Object actual) {
         this.lastMismatch = null;
         if (actual == null) {
             return this.expected == null;
+        } else if ((actual instanceof Number) && (this.expected instanceof Number)) {
+            return checkNumbersAreOnlyUpcasted(actual, this.expected);
         } else {
-            if ((actual instanceof Number) && (this.expected instanceof Number)) {
-                return checkNumbersAreOnlyUpcasted(actual, this.expected);
-            } else {
-                return actual.getClass().equals(this.expected.getClass());
-            }
+            return actual.getClass().equals(this.expected.getClass());
         }
+
     }
 
     private UpcastOnlyCellMatcher(final T expected) {