From 5388761f4654a4616f52b3ccd7dda961d554a716 Mon Sep 17 00:00:00 2001 From: ckunki Date: Fri, 15 Mar 2024 11:03:01 +0100 Subject: [PATCH 1/4] Updated link to claudera impala page and dependencies --- .gitattributes | 25 ++- .github/workflows/broken_links_checker.yml | 20 +- .github/workflows/ci-build-next-java.yml | 22 +- .github/workflows/ci-build.yml | 90 ++++++-- .github/workflows/dependencies_check.yml | 72 +++++-- .github/workflows/dependencies_update.yml | 175 ++++++++++++++++ .github/workflows/release.yml | 193 ++++++++++++++++++ ...elease_droid_prepare_original_checksum.yml | 31 --- .../release_droid_print_quick_checksum.yml | 24 --- ...ase_droid_upload_github_release_assets.yml | 44 ---- .settings/org.eclipse.jdt.core.prefs | 2 +- dependencies.md | 99 +++++---- doc/changes/changelog.md | 1 + doc/changes/changes_2.0.1.md | 37 ++++ doc/user_guide/impala_user_guide.md | 4 +- pk_generated_parent.pom | 91 ++++++++- pom.xml | 14 +- 17 files changed, 722 insertions(+), 222 deletions(-) create mode 100644 .github/workflows/dependencies_update.yml create mode 100644 .github/workflows/release.yml delete mode 100644 .github/workflows/release_droid_prepare_original_checksum.yml delete mode 100644 .github/workflows/release_droid_print_quick_checksum.yml delete mode 100644 .github/workflows/release_droid_upload_github_release_assets.yml create mode 100644 doc/changes/changes_2.0.1.md diff --git a/.gitattributes b/.gitattributes index 90163ac..f22be2f 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1,13 +1,12 @@ -pk_generated_parent.pom linguist-generated=true -dependencies.md linguist-generated=true -versionsMavenPluginRules.xml linguist-generated=true -doc/changes/changelog.md linguist-generated=true -.github/workflows/broken_links_checker.yml linguist-generated=true -.github/workflows/ci-build-next-java.yml linguist-generated=true -.github/workflows/ci-build.yml linguist-generated=true -.github/workflows/dependencies_check.yml linguist-generated=true -.github/workflows/release_droid_prepare_original_checksum.yml linguist-generated=true -.github/workflows/release_droid_print_quick_checksum.yml linguist-generated=true -.github/workflows/release_droid_upload_github_release_assets.yml linguist-generated=true -.settings/org.eclipse.jdt.core.prefs linguist-generated=true -.settings/org.eclipse.jdt.ui.prefs linguist-generated=true +pk_generated_parent.pom linguist-generated=true +dependencies.md linguist-generated=true +versionsMavenPluginRules.xml linguist-generated=true +doc/changes/changelog.md linguist-generated=true +.github/workflows/broken_links_checker.yml linguist-generated=true +.github/workflows/ci-build-next-java.yml linguist-generated=true +.github/workflows/ci-build.yml linguist-generated=true +.github/workflows/dependencies_check.yml linguist-generated=true +.github/workflows/dependencies_update.yml linguist-generated=true +.github/workflows/release.yml linguist-generated=true +.settings/org.eclipse.jdt.core.prefs linguist-generated=true +.settings/org.eclipse.jdt.ui.prefs linguist-generated=true diff --git a/.github/workflows/broken_links_checker.yml b/.github/workflows/broken_links_checker.yml index 29071df..d7a38b4 100644 --- a/.github/workflows/broken_links_checker.yml +++ b/.github/workflows/broken_links_checker.yml @@ -1,3 +1,5 @@ +# Generated by Project Keeper +# https://github.com/exasol/project-keeper/blob/main/project-keeper/src/main/resources/templates/.github/workflows/broken_links_checker.yml name: Broken Links Checker on: @@ -11,17 +13,25 @@ on: jobs: linkChecker: runs-on: ubuntu-latest + defaults: + run: + shell: "bash" concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: true steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Configure broken links checker run: | mkdir -p ./target - echo '{ "aliveStatusCodes": [429, 200], "ignorePatterns": [{"pattern": "^https?://(www.)?opensource.org"}] }' > ./target/broken_links_checker.json + echo '{"aliveStatusCodes": [429, 200], "ignorePatterns": [' \ + '{"pattern": "^https?://(www|dev).mysql.com/"},' \ + '{"pattern": "^https?://(www.)?opensource.org"}' \ + '{"pattern": "^https?://(www.)?eclipse.org"}' \ + '{"pattern": "^https?://projects.eclipse.org"}' \ + ']}' > ./target/broken_links_checker.json - uses: gaurav-nelson/github-action-markdown-link-check@v1 with: - use-quiet-mode: 'yes' - use-verbose-mode: 'yes' - config-file: ./target/broken_links_checker.json \ No newline at end of file + use-quiet-mode: "yes" + use-verbose-mode: "yes" + config-file: ./target/broken_links_checker.json diff --git a/.github/workflows/ci-build-next-java.yml b/.github/workflows/ci-build-next-java.yml index 6a1006c..8886e10 100644 --- a/.github/workflows/ci-build-next-java.yml +++ b/.github/workflows/ci-build-next-java.yml @@ -1,5 +1,6 @@ +# Generated by Project Keeper +# https://github.com/exasol/project-keeper/blob/main/project-keeper/src/main/resources/templates/.github/workflows/ci-build-next-java.yml name: CI Build next Java - on: push: branches: @@ -9,25 +10,32 @@ on: jobs: java-17-compatibility: runs-on: ubuntu-latest + defaults: + run: + shell: "bash" + permissions: + contents: read + checks: write # Allow scacap/action-surefire-report concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: true steps: - name: Checkout the repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 - name: Set up JDK 17 - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: - distribution: 'temurin' + distribution: "temurin" java-version: 17 - cache: 'maven' + cache: "maven" - name: Run tests and build with Maven run: | - mvn --batch-mode --update-snapshots clean package -DtrimStackTrace=false \ + mvn --batch-mode --update-snapshots clean package -DtrimStackTrace=false \ + -Djava.version=17 \ -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn - - name: Publish Test Report + - name: Publish Test Report for Java 17 uses: scacap/action-surefire-report@v1 if: ${{ always() && github.event.pull_request.head.repo.full_name == github.repository && github.actor != 'dependabot[bot]' }} with: diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index e520870..4989aba 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -1,30 +1,43 @@ +# Generated by Project Keeper +# https://github.com/exasol/project-keeper/blob/main/project-keeper/src/main/resources/templates/.github/workflows/ci-build.yml name: CI Build - on: push: - branches: - - main + branches: ["main"] pull_request: jobs: build: runs-on: ubuntu-latest + defaults: + run: + shell: "bash" + permissions: + contents: read + checks: write # Allow scacap/action-surefire-report concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: true steps: + - name: Free Disk Space + if: ${{ false }} + run: | + sudo rm -rf /usr/local/lib/android + sudo rm -rf /usr/share/dotnet - name: Checkout the repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 - - name: Set up JDK 11 - uses: actions/setup-java@v3 + - name: Set up JDKs + uses: actions/setup-java@v4 with: - distribution: 'temurin' - java-version: 11 - cache: 'maven' + distribution: "temurin" + java-version: | + 11 + 17 + cache: "maven" - name: Cache SonarCloud packages - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.sonar/cache key: ${{ runner.os }}-sonar @@ -32,6 +45,7 @@ jobs: - name: Enable testcontainer reuse run: echo 'testcontainers.reuse.enable=true' > "$HOME/.testcontainers.properties" - name: Run tests and build with Maven + id: pk-verify run: | mvn --batch-mode clean verify \ -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \ @@ -47,9 +61,57 @@ jobs: mvn --batch-mode org.sonarsource.scanner.maven:sonar-maven-plugin:sonar \ -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \ -DtrimStackTrace=false \ - -Dsonar.organization=exasol \ - -Dsonar.host.url=https://sonarcloud.io \ - -Dsonar.login=$SONAR_TOKEN + -Dsonar.token=$SONAR_TOKEN env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} \ No newline at end of file + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + + - name: Verify Release Artifacts + run: | + print_message() { + local -r message=$1 + echo "$message" + echo "$message" >> "$GITHUB_STEP_SUMMARY" + } + + print_message "# Release Artifacts" + + IFS=$'\n' artifacts_array=($ARTIFACTS) + missing_files=() + for file in "${artifacts_array[@]}"; + do + echo "Checking if file $file exists..." + if ! [[ -f "$file" ]]; then + print_message "* ⚠️ \`$file\` does not exist ⚠️" + echo "Content of directory $(dirname "$file"):" + ls "$(dirname "$file")" + missing_files+=("$file") + else + print_message "* \`$file\` ✅" + fi + done + print_message "" + number_of_missing_files=${#missing_files[@]} + if [[ $number_of_missing_files -gt 0 ]]; then + print_message "⚠️ $number_of_missing_files release artifact(s) missing ⚠️" + exit 1 + else + print_message "All ${#artifacts_array[@]} artifact(s) present ✅" + fi + env: + ARTIFACTS: ${{ steps.pk-verify.outputs.release-artifacts }} + + # [impl->dsn~release-workflow.ci-build-starts-release~1] + start_release: + needs: build + if: ${{ github.ref == 'refs/heads/main' }} + concurrency: + cancel-in-progress: false + group: "release" + secrets: inherit + permissions: + contents: write + actions: read + uses: ./.github/workflows/release.yml + with: + started-from-ci: true diff --git a/.github/workflows/dependencies_check.yml b/.github/workflows/dependencies_check.yml index b2ab231..bd26ab6 100644 --- a/.github/workflows/dependencies_check.yml +++ b/.github/workflows/dependencies_check.yml @@ -1,20 +1,68 @@ -name: Dependencies Check - +# Generated by Project Keeper +# https://github.com/exasol/project-keeper/blob/main/project-keeper/src/main/resources/templates/.github/workflows/dependencies_check.yml +name: Report Security Issues on: + workflow_dispatch: schedule: - cron: "0 2 * * *" jobs: - build: + report_security_issues: runs-on: ubuntu-latest - + defaults: + run: + shell: "bash" + permissions: + contents: read + issues: write + outputs: + created-issues: ${{ steps.security-issues.outputs.created-issues }} steps: - - uses: actions/checkout@v3 - - name: Set up JDK 11 - uses: actions/setup-java@v3 + - uses: actions/checkout@v4 + + - name: Set up JDKs + uses: actions/setup-java@v4 + with: + distribution: "temurin" + java-version: | + 11 + 17 + cache: "maven" + + - name: Generate ossindex report + run: | + mvn --batch-mode org.sonatype.ossindex.maven:ossindex-maven-plugin:audit \ + org.sonatype.ossindex.maven:ossindex-maven-plugin:audit-aggregate \ + -Dossindex.reportFile=$(pwd)/ossindex-report.json \ + -Dossindex.fail=false + + - name: Report Security Issues + id: security-issues + uses: exasol/python-toolbox/.github/actions/security-issues@main with: - distribution: 'temurin' - java-version: 11 - cache: 'maven' - - name: Checking dependencies for vulnerabilities - run: mvn --batch-mode org.sonatype.ossindex.maven:ossindex-maven-plugin:audit -f pom.xml \ No newline at end of file + format: "maven" + command: "cat ossindex-report.json" + github-token: ${{ secrets.GITHUB_TOKEN }} + + - name: Output security issues (Debugging) + run: | + echo "$CREATED_ISSUES" > test.jsonl + cat test.jsonl + env: + CREATED_ISSUES: ${{ steps.security-issues.outputs.created-issues }} + + start_dependency_udpate: + needs: report_security_issues + # [impl->dsn~trigger-dependency-updates~1] + if: ${{ needs.report_security_issues.outputs.created-issues }} + concurrency: + cancel-in-progress: true + group: "dependencies_update" + # Workflow needs secret INTEGRATION_TEAM_SLACK_NOTIFICATION_WEBHOOK + secrets: inherit + permissions: + contents: write + pull-requests: write + uses: ./.github/workflows/dependencies_update.yml + with: + vulnerability_issues: ${{ needs.report_security_issues.outputs.created-issues }} diff --git a/.github/workflows/dependencies_update.yml b/.github/workflows/dependencies_update.yml new file mode 100644 index 0000000..0f6b816 --- /dev/null +++ b/.github/workflows/dependencies_update.yml @@ -0,0 +1,175 @@ +# Generated by Project Keeper +# https://github.com/exasol/project-keeper/blob/main/project-keeper/src/main/resources/templates/.github/workflows/dependencies_update.yml +name: Update dependencies +on: + workflow_call: + inputs: + # [impl->dsn~dependency-updater.workflow.vulnerability-info~1] + vulnerability_issues: + description: "GitHub issues for vulnerable dependencies as JSONL" + required: true + type: string + workflow_dispatch: + +jobs: + update_dependencies: + runs-on: ubuntu-latest + defaults: + run: + shell: "bash" + permissions: + contents: write + pull-requests: write + + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 0 + + - name: Set up JDKs + uses: actions/setup-java@v4 + with: + distribution: "temurin" + java-version: | + 11 + 17 + cache: "maven" + + - name: Print issues + run: | + echo "Issues from Action input: $ISSUES" + env: + ISSUES: ${{ inputs.vulnerability_issues }} + + - name: Fail if not running on a branch + if: ${{ !startsWith(github.ref, 'refs/heads/') }} + uses: actions/github-script@v7 + with: + script: | + core.setFailed('Not running on a branch, github.ref is ${{ github.ref }}. Please start this workflow only on main or a branch') + + - name: Update dependencies + # [impl->dsn~dependency-updater.workflow.start-pk-update~1] + run: | + mvn --batch-mode com.exasol:project-keeper-maven-plugin:update-dependencies --projects . \ + -Dproject-keeper:vulnerabilities="$CREATED_ISSUES" + env: + CREATED_ISSUES: ${{ inputs.vulnerability_issues }} + + - name: Project Keeper Fix + run: | + mvn --batch-mode com.exasol:project-keeper-maven-plugin:fix --projects . + + - name: Project Keeper Fix for updated Project Keeper version + # Calling PK fix a second time is necessary because the first invocation potentially updated PK itself. + # So we need to run PK fix again with the latest PK version. + # [impl->dsn~dependency-updater.workflow.start-pk-fix~1] + run: | + mvn --batch-mode com.exasol:project-keeper-maven-plugin:fix --projects . + + - name: Generate Pull Request comment + id: pr-comment + # [impl->dsn~dependency-updater.workflow.create-pull-request~1] + # [impl->dsn~dependency-updater.workflow.pull-request-trigger-ci-build~1] + run: | + echo 'comment<> "$GITHUB_OUTPUT" + echo 'This Pull Request was created by [`dependencies_update.yml`](https://github.com/exasol/project-keeper/blob/main/project-keeper/src/main/resources/templates/.github/workflows/dependencies_update.yml) workflow.' >> "$GITHUB_OUTPUT" + if [ -n "$CREATED_ISSUES" ]; then + echo 'It updates dependencies to fix the following vulnerabilities:' >> "$GITHUB_OUTPUT" + echo $CREATED_ISSUES | jq --raw-output '. | "* Closes " + .issue_url + " (" + .cve + ")"' >> "$GITHUB_OUTPUT" + else + echo 'It updates dependencies.' >> "$GITHUB_OUTPUT" + fi + echo >> "$GITHUB_OUTPUT" + echo '# ⚠️ This PR does not trigger CI workflows by default ⚠️' >> "$GITHUB_OUTPUT" + echo 'Please click the **Close pull request** button and then **Reopen pull request** to trigger running checks.' >> "$GITHUB_OUTPUT" + echo 'See https://github.com/exasol/project-keeper/issues/534 for details.' >> "$GITHUB_OUTPUT" + echo 'EOF' >> "$GITHUB_OUTPUT" + + cat "$GITHUB_OUTPUT" + env: + CREATED_ISSUES: ${{ inputs.vulnerability_issues }} + + - name: Generate Pull Request Title + id: pr-title + run: | + if [ -n "$CREATED_ISSUES" ]; then + echo "Security issues are available" + echo "title=🔐 Update dependencies to fix vulnerabilities" >> "$GITHUB_OUTPUT" + else + echo "Security issues are not available" + echo "title=Update dependencies" >> "$GITHUB_OUTPUT" + fi + + cat "$GITHUB_OUTPUT" + env: + CREATED_ISSUES: ${{ inputs.vulnerability_issues }} + + - name: Configure git + run: | + git config --global user.email "opensource@exasol.com" + git config --global user.name "Automatic Dependency Updater" + + - name: Create branch + if: ${{ github.ref == 'refs/heads/main' }} + run: | + branch_name="dependency-update/$(date "+%Y%m%d%H%M%S")" + echo "Creating branch $branch_name" + git checkout -b "$branch_name" + + - name: Commit changes & push + if: ${{ startsWith(github.ref, 'refs/heads/' ) }} + run: | + branch_name=$(git rev-parse --abbrev-ref HEAD) + echo "Current branch: $branch_name" + echo "git diff --stat" + git diff --stat + echo "git diff --numstat" + git diff --numstat + echo "git diff --name-status" + git diff --name-status + echo "Adding untracked files:" + git add . --verbose --all + echo "Committing changes..." + git commit --message "$TITLE" + echo "Pushing branch $branch_name..." + git push --set-upstream origin "$branch_name" + echo "Done." + env: + TITLE: ${{ steps.pr-title.outputs.title }} + + - name: Create pull request + id: create-pr + if: ${{ github.ref == 'refs/heads/main' }} + run: | + pr_url=$(gh pr create --base main --title "$TITLE" --body "$COMMENT") + echo "Created Pull Request: $pr_url" + echo "pr_url=$pr_url" >> "$GITHUB_OUTPUT" + env: + COMMENT: ${{ steps.pr-comment.outputs.comment }} + TITLE: ${{ steps.pr-title.outputs.title }} + GH_TOKEN: ${{ github.token }} + + - name: Report failure Status to Slack channel + # Also run this step in case of failures + if: ${{ always() }} + uses: ravsamhq/notify-slack-action@v2 + with: + status: ${{ job.status }} + token: ${{ secrets.GITHUB_TOKEN }} + notification_title: "Dependency check in {repo} has {status_message}" + message_format: "{emoji} *{workflow}* {status_message} in <{repo_url}|{repo}>" + notify_when: "failure,cancelled,warnings" + env: + SLACK_WEBHOOK_URL: ${{ secrets.INTEGRATION_TEAM_SLACK_NOTIFICATION_WEBHOOK }} + + - name: Report new Pull Request to Slack channel + if: ${{ steps.create-pr.outputs.pr_url }} + uses: ravsamhq/notify-slack-action@v2 + with: + status: ${{ job.status }} + token: ${{ secrets.GITHUB_TOKEN }} + notification_title: "Dependency update for {repo} created a Pull Request" + message_format: "{workflow} created Pull Request ${{ steps.create-pr.outputs.pr_url }}" + env: + SLACK_WEBHOOK_URL: ${{ secrets.INTEGRATION_TEAM_SLACK_NOTIFICATION_WEBHOOK }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml new file mode 100644 index 0000000..7a2dc9c --- /dev/null +++ b/.github/workflows/release.yml @@ -0,0 +1,193 @@ +# Generated by Project Keeper +# https://github.com/exasol/project-keeper/blob/main/project-keeper/src/main/resources/templates/.github/workflows/release.yml +name: Release +on: + # [impl->dsn~release-workflow.triggers~1] + workflow_call: + inputs: + started-from-ci: + description: "Marks this release as started from CI, skipping precondition check" + type: boolean + required: true + default: false + workflow_dispatch: + inputs: + skip-maven-central: + description: "Skip deployment to Maven Central" + required: true + type: boolean + default: false + skip-github-release: + description: "Skip creating the GitHub release" + required: true + type: boolean + default: false + +jobs: + release: + runs-on: ubuntu-latest + defaults: + run: + shell: "bash" + concurrency: + group: ${{ github.workflow }} + cancel-in-progress: false + permissions: + contents: write + actions: read + steps: + - name: Checkout the repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + - name: Set up Maven Central Repository + if: ${{ false }} + uses: actions/setup-java@v4 + with: + distribution: "temurin" + java-version: | + 11 + 17 + cache: "maven" + server-id: ossrh + server-username: MAVEN_USERNAME + server-password: MAVEN_PASSWORD + gpg-private-key: ${{ secrets.OSSRH_GPG_SECRET_KEY }} + gpg-passphrase: MAVEN_GPG_PASSPHRASE + - name: Set up JDKs + if: ${{ ! false }} + uses: actions/setup-java@v4 + with: + distribution: "temurin" + java-version: | + 11 + 17 + cache: "maven" + + # Check preconditions + + - name: Fail if not running on main branch + if: ${{ github.ref != 'refs/heads/main' }} + uses: actions/github-script@v7 + with: + script: | + core.setFailed('Not running on main branch, github.ref is ${{ github.ref }}. Please start this workflow only on main') + + # [impl->dsn~release-workflow.verify-ci-build-success~1] + - name: Check CI build of this commit succeeded + # We skip this check if this was started from ci-build.yml, because the build status would be "in progress". + if: ${{ ! inputs.started-from-ci }} + run: | + echo "Commit SHA: $COMMIT_SHA" + gh run list --workflow ci-build.yml --branch main --event push --commit $COMMIT_SHA + ci_build_status=$(gh run list --workflow ci-build.yml --branch main --event push --commit $COMMIT_SHA --json conclusion --template '{{range .}}{{.conclusion}}{{"\n"}}{{end}}') + echo "CI build status at commit $COMMIT_SHA was '$ci_build_status'" + if [[ "$ci_build_status" != "success" ]]; then + gh run list --workflow ci-build.yml --commit $COMMIT_SHA >> $GITHUB_STEP_SUMMARY + echo "Status of CI build for commit $COMMIT_SHA was '$ci_build_status', expected 'success'" >> $GITHUB_STEP_SUMMARY + cat $GITHUB_STEP_SUMMARY + exit 1 + fi + env: + COMMIT_SHA: ${{ github.sha }} + GH_TOKEN: ${{ github.token }} + # [impl->dsn~release-workflow.run-verify-release~1] + - name: Verify release preconditions + id: verify-release + run: | + mvn --batch-mode com.exasol:project-keeper-maven-plugin:verify-release --projects . + echo "$GITHUB_OUTPUT" + env: + GITHUB_TOKEN: ${{ github.token }} + # [impl->dsn~release-workflow.verify-skip-tests~1] + - name: Build project + run: mvn --batch-mode -DskipTests clean verify + + # Maven Central Deployment + - name: List secret GPG keys + if: ${{ false && (! inputs.skip-maven-central) }} + run: gpg --list-secret-keys + # [impl->dsn~release-workflow.deploy-maven-central~1] + - name: Publish to Central Repository + if: ${{ false && (! inputs.skip-maven-central) }} + run: | + mvn --batch-mode -Dgpg.skip=false -DskipTests deploy + echo "Published to Maven Central" >> "$GITHUB_STEP_SUMMARY" + env: + MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }} + MAVEN_PASSWORD: ${{ secrets.OSSRH_PASSWORD }} + MAVEN_GPG_PASSPHRASE: ${{ secrets.OSSRH_GPG_SECRET_KEY_PASSWORD }} + + # Create GitHub releasse + + - name: Calculate Artifact Checksums + id: artifact-checksum + if: ${{ ! inputs.skip-github-release }} + run: | + ls target/ + echo "Calculating sha256 checksum for artifact files" + echo "artifacts<> "$GITHUB_OUTPUT" + IFS=$'\n' artifacts_array=($ARTIFACTS) + for file in "${artifacts_array[@]}"; + do + full_path=$(realpath "$file") + echo "Calculate sha256sum for file '$full_path'" + file_dir="$(dirname "$full_path")" + file_name=$(basename "$full_path") + pushd "$file_dir" + checksum_file_name="${file_name}.sha256" + sha256sum "$file_name" > "$checksum_file_name" + echo "$full_path" >> "$GITHUB_OUTPUT" + echo "${file_dir}/$checksum_file_name" >> "$GITHUB_OUTPUT" + popd + done + echo "EOF" >> "$GITHUB_OUTPUT" + echo "Full artifact file list" + cat "$GITHUB_OUTPUT" + env: + ARTIFACTS: ${{ steps.verify-release.outputs.release-artifacts }} + + # [impl->dsn~release-workflow.create-github-release~1] + - name: Create GitHub Release + id: create-github-release + if: ${{ ! inputs.skip-github-release }} + run: | + IFS=$'\n' artifacts_array=($ARTIFACTS) + for file in "${artifacts_array[@]}"; + do + echo "Attaching file '$file'" + done + release_url=$(gh release create --draft --latest --title "$TITLE" --notes "$NOTES" --target main $TAG "${artifacts_array[@]}") + echo "Created release $TAG with title '$TITLE' at $release_url" >> "$GITHUB_STEP_SUMMARY" + echo "release-url=$release_url" >> "$GITHUB_OUTPUT" + git fetch --tags origin + env: + GH_TOKEN: ${{ github.token }} + TAG: ${{ steps.verify-release.outputs.version }} + NOTES: ${{ steps.verify-release.outputs.release-notes }} + TITLE: ${{ steps.verify-release.outputs.release-title }} + ARTIFACTS: ${{ steps.artifact-checksum.outputs.artifacts }} + + - name: Report failure Status to Slack channel + # Also run this step in case of failures + if: ${{ always() }} + uses: ravsamhq/notify-slack-action@v2 + with: + status: ${{ job.status }} + token: ${{ github.token }} + notification_title: "Release build in {repo} has {status_message}" + message_format: "{emoji} *{workflow}* {status_message} in <{repo_url}|{repo}>" + notify_when: "failure,cancelled,warnings,skipped" + env: + SLACK_WEBHOOK_URL: ${{ secrets.INTEGRATION_TEAM_SLACK_NOTIFICATION_WEBHOOK }} + + - name: Report new release to Slack channel + if: ${{ steps.create-github-release.outputs.release-url }} + uses: ravsamhq/notify-slack-action@v2 + with: + status: ${{ job.status }} + token: ${{ github.token }} + notification_title: "Release build for {repo} created a new release" + message_format: "{workflow} created release ${{ steps.create-github-release.outputs.release-url }}" + env: + SLACK_WEBHOOK_URL: ${{ secrets.INTEGRATION_TEAM_SLACK_NOTIFICATION_WEBHOOK }} diff --git a/.github/workflows/release_droid_prepare_original_checksum.yml b/.github/workflows/release_droid_prepare_original_checksum.yml deleted file mode 100644 index 4a980f8..0000000 --- a/.github/workflows/release_droid_prepare_original_checksum.yml +++ /dev/null @@ -1,31 +0,0 @@ -name: Release Droid - Prepare Original Checksum - -on: - workflow_dispatch: - -jobs: - build: - runs-on: ubuntu-latest - steps: - - name: Checkout the repository - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - name: Set up JDK 11 - uses: actions/setup-java@v3 - with: - distribution: 'temurin' - java-version: 11 - cache: 'maven' - - name: Enable testcontainer reuse - run: echo 'testcontainers.reuse.enable=true' > "$HOME/.testcontainers.properties" - - name: Run tests and build with Maven - run: mvn --batch-mode clean verify --file pom.xml - - name: Prepare checksum - run: find target -maxdepth 1 -name *.jar -exec sha256sum "{}" + > original_checksum - - name: Upload checksum to the artifactory - uses: actions/upload-artifact@v3 - with: - name: original_checksum - retention-days: 5 - path: original_checksum \ No newline at end of file diff --git a/.github/workflows/release_droid_print_quick_checksum.yml b/.github/workflows/release_droid_print_quick_checksum.yml deleted file mode 100644 index 8add957..0000000 --- a/.github/workflows/release_droid_print_quick_checksum.yml +++ /dev/null @@ -1,24 +0,0 @@ -name: Release Droid - Print Quick Checksum - -on: - workflow_dispatch: - -jobs: - build: - runs-on: ubuntu-latest - steps: - - name: Checkout the repository - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - name: Set up JDK 11 - uses: actions/setup-java@v3 - with: - distribution: 'temurin' - java-version: 11 - cache: 'maven' - - name: Build with Maven skipping tests - run: mvn --batch-mode clean verify -DskipTests - - name: Print checksum - run: echo 'checksum_start==';find target -maxdepth 1 -name *.jar -exec sha256sum "{}" + | xargs;echo '==checksum_end' - diff --git a/.github/workflows/release_droid_upload_github_release_assets.yml b/.github/workflows/release_droid_upload_github_release_assets.yml deleted file mode 100644 index 7350faf..0000000 --- a/.github/workflows/release_droid_upload_github_release_assets.yml +++ /dev/null @@ -1,44 +0,0 @@ -name: Release Droid - Upload GitHub Release Assets - -on: - workflow_dispatch: - inputs: - upload_url: - description: 'Assets upload URL' - required: true - -jobs: - build: - runs-on: ubuntu-latest - steps: - - name: Checkout the repository - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - name: Set up JDK 11 - uses: actions/setup-java@v3 - with: - distribution: 'temurin' - java-version: 11 - cache: 'maven' - - name: Build with Maven skipping tests - run: mvn --batch-mode clean verify -DskipTests - - name: Generate sha256sum files - run: | - cd target - find . -maxdepth 1 -name \*.jar -exec bash -c 'sha256sum {} > {}.sha256' \; - - name: Upload assets to the GitHub release draft - uses: shogo82148/actions-upload-release-asset@v1 - with: - upload_url: ${{ github.event.inputs.upload_url }} - asset_path: target/*.jar - - name: Upload sha256sum files - uses: shogo82148/actions-upload-release-asset@v1 - with: - upload_url: ${{ github.event.inputs.upload_url }} - asset_path: target/*.sha256 - - name: Upload error-code-report - uses: shogo82148/actions-upload-release-asset@v1 - with: - upload_url: ${{ github.event.inputs.upload_url }} - asset_path: target/error_code_report.json diff --git a/.settings/org.eclipse.jdt.core.prefs b/.settings/org.eclipse.jdt.core.prefs index 8b5a9aa..bb40c3f 100644 --- a/.settings/org.eclipse.jdt.core.prefs +++ b/.settings/org.eclipse.jdt.core.prefs @@ -111,7 +111,7 @@ org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=ignore org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning -org.eclipse.jdt.core.compiler.processAnnotations=enabled +org.eclipse.jdt.core.compiler.processAnnotations=disabled org.eclipse.jdt.core.compiler.release=disabled org.eclipse.jdt.core.compiler.source=11 org.eclipse.jdt.core.formatter.align_assignment_statements_on_columns=false diff --git a/dependencies.md b/dependencies.md index 3de42a4..a8fdcba 100644 --- a/dependencies.md +++ b/dependencies.md @@ -10,37 +10,34 @@ ## Test Dependencies -| Dependency | License | -| ---------------------------------------- | -------------------------------- | -| [EqualsVerifier | release normal jar][4] | [Apache License, Version 2.0][5] | -| [Virtual Schema Common JDBC][0] | [MIT License][1] | -| [Hamcrest][6] | [BSD License 3][7] | -| [JUnit Jupiter (Aggregator)][8] | [Eclipse Public License v2.0][9] | -| [mockito-junit-jupiter][10] | [The MIT License][11] | +| Dependency | License | +| ----------------------------------------- | -------------------------------- | +| [EqualsVerifier \| release normal jar][4] | [Apache License, Version 2.0][5] | +| [Virtual Schema Common JDBC][0] | [MIT License][1] | +| [Hamcrest][6] | [BSD License 3][7] | +| [JUnit Jupiter (Aggregator)][8] | [Eclipse Public License v2.0][9] | +| [mockito-junit-jupiter][10] | [MIT][11] | ## Plugin Dependencies -| Dependency | License | -| ------------------------------------------------------- | ---------------------------------------------- | -| [SonarQube Scanner for Maven][12] | [GNU LGPL 3][13] | -| [Apache Maven Compiler Plugin][14] | [Apache License, Version 2.0][5] | -| [Apache Maven Enforcer Plugin][15] | [Apache License, Version 2.0][5] | -| [Maven Flatten Plugin][16] | [Apache Software Licenese][5] | -| [org.sonatype.ossindex.maven:ossindex-maven-plugin][17] | [ASL2][18] | -| [Maven Surefire Plugin][19] | [Apache License, Version 2.0][5] | -| [Versions Maven Plugin][20] | [Apache License, Version 2.0][5] | -| [Apache Maven Assembly Plugin][21] | [Apache License, Version 2.0][5] | -| [Apache Maven JAR Plugin][22] | [Apache License, Version 2.0][5] | -| [Artifact reference checker and unifier][23] | [MIT License][24] | -| [JaCoCo :: Maven Plugin][25] | [Eclipse Public License 2.0][26] | -| [error-code-crawler-maven-plugin][27] | [MIT License][28] | -| [Reproducible Build Maven Plugin][29] | [Apache 2.0][18] | -| [Project keeper maven plugin][30] | [The MIT License][31] | -| [Maven Clean Plugin][32] | [The Apache Software License, Version 2.0][18] | -| [Maven Resources Plugin][33] | [The Apache Software License, Version 2.0][18] | -| [Maven Install Plugin][34] | [The Apache Software License, Version 2.0][18] | -| [Maven Deploy Plugin][35] | [The Apache Software License, Version 2.0][18] | -| [Maven Site Plugin 3][36] | [The Apache Software License, Version 2.0][18] | +| Dependency | License | +| ------------------------------------------------------- | -------------------------------- | +| [SonarQube Scanner for Maven][12] | [GNU LGPL 3][13] | +| [Apache Maven Toolchains Plugin][14] | [Apache License, Version 2.0][5] | +| [Apache Maven Compiler Plugin][15] | [Apache-2.0][5] | +| [Apache Maven Enforcer Plugin][16] | [Apache-2.0][5] | +| [Maven Flatten Plugin][17] | [Apache Software Licenese][5] | +| [org.sonatype.ossindex.maven:ossindex-maven-plugin][18] | [ASL2][19] | +| [Maven Surefire Plugin][20] | [Apache-2.0][5] | +| [Versions Maven Plugin][21] | [Apache License, Version 2.0][5] | +| [duplicate-finder-maven-plugin Maven Mojo][22] | [Apache License 2.0][23] | +| [Apache Maven Assembly Plugin][24] | [Apache-2.0][5] | +| [Apache Maven JAR Plugin][25] | [Apache License, Version 2.0][5] | +| [Artifact reference checker and unifier][26] | [MIT License][27] | +| [JaCoCo :: Maven Plugin][28] | [Eclipse Public License 2.0][29] | +| [error-code-crawler-maven-plugin][30] | [MIT License][31] | +| [Reproducible Build Maven Plugin][32] | [Apache 2.0][19] | +| [Project Keeper Maven plugin][33] | [The MIT License][34] | [0]: https://github.com/exasol/virtual-schema-common-jdbc/ [1]: https://github.com/exasol/virtual-schema-common-jdbc/blob/main/LICENSE @@ -53,29 +50,27 @@ [8]: https://junit.org/junit5/ [9]: https://www.eclipse.org/legal/epl-v20.html [10]: https://github.com/mockito/mockito -[11]: https://github.com/mockito/mockito/blob/main/LICENSE +[11]: https://opensource.org/licenses/MIT [12]: http://sonarsource.github.io/sonar-scanner-maven/ [13]: http://www.gnu.org/licenses/lgpl.txt -[14]: https://maven.apache.org/plugins/maven-compiler-plugin/ -[15]: https://maven.apache.org/enforcer/maven-enforcer-plugin/ -[16]: https://www.mojohaus.org/flatten-maven-plugin/ -[17]: https://sonatype.github.io/ossindex-maven/maven-plugin/ -[18]: http://www.apache.org/licenses/LICENSE-2.0.txt -[19]: https://maven.apache.org/surefire/maven-surefire-plugin/ -[20]: https://www.mojohaus.org/versions-maven-plugin/ -[21]: https://maven.apache.org/plugins/maven-assembly-plugin/ -[22]: https://maven.apache.org/plugins/maven-jar-plugin/ -[23]: https://github.com/exasol/artifact-reference-checker-maven-plugin/ -[24]: https://github.com/exasol/artifact-reference-checker-maven-plugin/blob/main/LICENSE -[25]: https://www.jacoco.org/jacoco/trunk/doc/maven.html -[26]: https://www.eclipse.org/legal/epl-2.0/ -[27]: https://github.com/exasol/error-code-crawler-maven-plugin/ -[28]: https://github.com/exasol/error-code-crawler-maven-plugin/blob/main/LICENSE -[29]: http://zlika.github.io/reproducible-build-maven-plugin -[30]: https://github.com/exasol/project-keeper/ -[31]: https://github.com/exasol/project-keeper/blob/main/LICENSE -[32]: http://maven.apache.org/plugins/maven-clean-plugin/ -[33]: http://maven.apache.org/plugins/maven-resources-plugin/ -[34]: http://maven.apache.org/plugins/maven-install-plugin/ -[35]: http://maven.apache.org/plugins/maven-deploy-plugin/ -[36]: http://maven.apache.org/plugins/maven-site-plugin/ +[14]: https://maven.apache.org/plugins/maven-toolchains-plugin/ +[15]: https://maven.apache.org/plugins/maven-compiler-plugin/ +[16]: https://maven.apache.org/enforcer/maven-enforcer-plugin/ +[17]: https://www.mojohaus.org/flatten-maven-plugin/ +[18]: https://sonatype.github.io/ossindex-maven/maven-plugin/ +[19]: http://www.apache.org/licenses/LICENSE-2.0.txt +[20]: https://maven.apache.org/surefire/maven-surefire-plugin/ +[21]: https://www.mojohaus.org/versions/versions-maven-plugin/ +[22]: https://basepom.github.io/duplicate-finder-maven-plugin +[23]: http://www.apache.org/licenses/LICENSE-2.0.html +[24]: https://maven.apache.org/plugins/maven-assembly-plugin/ +[25]: https://maven.apache.org/plugins/maven-jar-plugin/ +[26]: https://github.com/exasol/artifact-reference-checker-maven-plugin/ +[27]: https://github.com/exasol/artifact-reference-checker-maven-plugin/blob/main/LICENSE +[28]: https://www.jacoco.org/jacoco/trunk/doc/maven.html +[29]: https://www.eclipse.org/legal/epl-2.0/ +[30]: https://github.com/exasol/error-code-crawler-maven-plugin/ +[31]: https://github.com/exasol/error-code-crawler-maven-plugin/blob/main/LICENSE +[32]: http://zlika.github.io/reproducible-build-maven-plugin +[33]: https://github.com/exasol/project-keeper/ +[34]: https://github.com/exasol/project-keeper/blob/main/LICENSE diff --git a/doc/changes/changelog.md b/doc/changes/changelog.md index 56abc9b..07033bc 100644 --- a/doc/changes/changelog.md +++ b/doc/changes/changelog.md @@ -1,4 +1,5 @@ # Changes +* [2.0.1](changes_2.0.1.md) * [2.0.0](changes_2.0.0.md) * [1.0.0](changes_1.0.0.md) diff --git a/doc/changes/changes_2.0.1.md b/doc/changes/changes_2.0.1.md new file mode 100644 index 0000000..6910006 --- /dev/null +++ b/doc/changes/changes_2.0.1.md @@ -0,0 +1,37 @@ +# Virtual Schema for Impala 2.0.1, released 2024-??-?? + +Code name: + +## Summary + +## Documentation + +* #18: Updated link to claudera impala page and dependencies + +## Dependency Updates + +### Compile Dependency Updates + +* Updated `com.exasol:virtual-schema-common-jdbc:10.1.0` to `12.0.0` + +### Test Dependency Updates + +* Updated `com.exasol:virtual-schema-common-jdbc:10.1.0` to `12.0.0` +* Updated `nl.jqno.equalsverifier:equalsverifier:3.12.1` to `3.15.8` +* Updated `org.junit.jupiter:junit-jupiter:5.9.0` to `5.10.2` +* Updated `org.mockito:mockito-junit-jupiter:4.7.0` to `5.11.0` + +### Plugin Dependency Updates + +* Updated `com.exasol:error-code-crawler-maven-plugin:1.2.1` to `2.0.1` +* Updated `com.exasol:project-keeper-maven-plugin:2.9.1` to `4.2.0` +* Updated `org.apache.maven.plugins:maven-assembly-plugin:3.4.2` to `3.6.0` +* Updated `org.apache.maven.plugins:maven-compiler-plugin:3.10.1` to `3.12.1` +* Updated `org.apache.maven.plugins:maven-enforcer-plugin:3.1.0` to `3.4.1` +* Updated `org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7` to `3.2.5` +* Added `org.apache.maven.plugins:maven-toolchains-plugin:3.1.0` +* Added `org.basepom.maven:duplicate-finder-maven-plugin:2.0.1` +* Updated `org.codehaus.mojo:flatten-maven-plugin:1.3.0` to `1.6.0` +* Updated `org.codehaus.mojo:versions-maven-plugin:2.13.0` to `2.16.2` +* Updated `org.jacoco:jacoco-maven-plugin:0.8.8` to `0.8.11` +* Updated `org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184` to `3.10.0.2594` diff --git a/doc/user_guide/impala_user_guide.md b/doc/user_guide/impala_user_guide.md index ecc5e6d..f85b2d2 100644 --- a/doc/user_guide/impala_user_guide.md +++ b/doc/user_guide/impala_user_guide.md @@ -1,6 +1,6 @@ # Impala SQL Dialect -[Impala](https://www.cloudera.com/products/open-source/apache-hadoop/impala.html) is an MPP (Massive Parallel Processing) SQL query engine for processing data that is stored on a Hadoop cluster. +[Impala](https://docs.cloudera.com/cdw-runtime/cloud/impala-overview/topics/impala-overview.html) is an MPP (Massive Parallel Processing) SQL query engine for processing data that is stored on a Hadoop cluster. ## Registering the JDBC Driver in EXAOperation @@ -55,7 +55,7 @@ The SQL statement below creates the adapter script, defines the Java class that ```sql CREATE OR REPLACE JAVA ADAPTER SCRIPT ADAPTER.JDBC_ADAPTER AS %scriptclass com.exasol.adapter.RequestDispatcher; - %jar /buckets///virtual-schema-dist-10.1.0-impala-2.0.0.jar; + %jar /buckets///virtual-schema-dist-12.0.0-impala-2.0.1.jar; %jar /buckets///ImpalaJDBC41.jar; / ; diff --git a/pk_generated_parent.pom b/pk_generated_parent.pom index 8938845..a14d781 100644 --- a/pk_generated_parent.pom +++ b/pk_generated_parent.pom @@ -3,12 +3,14 @@ 4.0.0 com.exasol impala-virtual-schema-generated-parent - 2.0.0 + 2.0.1 pom UTF-8 UTF-8 11 + exasol + https://sonarcloud.io @@ -37,21 +39,46 @@ org.sonarsource.scanner.maven sonar-maven-plugin - 3.9.1.2184 + 3.10.0.2594 + + + org.apache.maven.plugins + maven-toolchains-plugin + 3.1.0 + + + + toolchain + + + + + + + ${java.version} + + + org.apache.maven.plugins maven-compiler-plugin - 3.10.1 + 3.12.1 ${java.version} ${java.version} + true + + + -Xlint:all,-processing + + org.apache.maven.plugins maven-enforcer-plugin - 3.1.0 + 3.4.1 enforce-maven @@ -63,6 +90,9 @@ 3.6.3 + + 17 + @@ -71,7 +101,7 @@ org.codehaus.mojo flatten-maven-plugin - 1.3.0 + 1.6.0 true oss @@ -110,7 +140,7 @@ org.apache.maven.plugins maven-surefire-plugin - 3.0.0-M7 + 3.2.5 @@ -121,7 +151,7 @@ org.codehaus.mojo versions-maven-plugin - 2.13.0 + 2.16.2 display-updates @@ -134,18 +164,59 @@ file:///${project.basedir}/versionsMavenPluginRules.xml + false + true + true + true + false + true + true + true + false + true + true + + + + org.basepom.maven + duplicate-finder-maven-plugin + 2.0.1 + + + default + verify + + check + + + + + true + true + true + true + true + true + false + true + false org.apache.maven.plugins maven-assembly-plugin - 3.4.2 + 3.6.0 src/assembly/all-dependencies.xml NAME_OF_YOUR_JAR false + + + true + + @@ -184,7 +255,7 @@ org.jacoco jacoco-maven-plugin - 0.8.8 + 0.8.11 prepare-agent @@ -225,7 +296,7 @@ com.exasol error-code-crawler-maven-plugin - 1.2.1 + 2.0.1 verify diff --git a/pom.xml b/pom.xml index 120aaff..a06bf56 100644 --- a/pom.xml +++ b/pom.xml @@ -3,18 +3,18 @@ 4.0.0 com.exasol impala-virtual-schema - 2.0.0 + 2.0.1 Virtual Schema for Impala Virtual Schema for connecting Impala as a data source to Exasol https://github.com/exasol/impala-virtual-schema/ impala-virtual-schema-generated-parent com.exasol - 2.0.0 + 2.0.1 pk_generated_parent.pom - 10.1.0 + 12.0.0 @@ -31,7 +31,7 @@ nl.jqno.equalsverifier equalsverifier - 3.12.1 + 3.15.8 test @@ -50,13 +50,13 @@ org.junit.jupiter junit-jupiter - 5.9.0 + 5.10.2 test org.mockito mockito-junit-jupiter - 4.7.0 + 5.11.0 test @@ -72,7 +72,7 @@ com.exasol project-keeper-maven-plugin - 2.9.1 + 4.2.0 From 59e8791298e03ad9b051eb2f197a772d6bd16b04 Mon Sep 17 00:00:00 2001 From: ckunki Date: Fri, 15 Mar 2024 11:19:04 +0100 Subject: [PATCH 2/4] Updated link to impala page and dependencies --- .settings/org.eclipse.core.resources.prefs | 6 ++ .settings/org.eclipse.m2e.core.prefs | 4 ++ dependencies.md | 68 +++++++++---------- pom.xml | 10 +++ .../dialects/impala/ImpalaSqlDialectTest.java | 10 +-- 5 files changed, 59 insertions(+), 39 deletions(-) create mode 100644 .settings/org.eclipse.core.resources.prefs create mode 100644 .settings/org.eclipse.m2e.core.prefs diff --git a/.settings/org.eclipse.core.resources.prefs b/.settings/org.eclipse.core.resources.prefs new file mode 100644 index 0000000..29abf99 --- /dev/null +++ b/.settings/org.eclipse.core.resources.prefs @@ -0,0 +1,6 @@ +eclipse.preferences.version=1 +encoding//src/main/java=UTF-8 +encoding//src/main/resources=UTF-8 +encoding//src/test/java=UTF-8 +encoding//src/test/resources=UTF-8 +encoding/=UTF-8 diff --git a/.settings/org.eclipse.m2e.core.prefs b/.settings/org.eclipse.m2e.core.prefs new file mode 100644 index 0000000..f897a7f --- /dev/null +++ b/.settings/org.eclipse.m2e.core.prefs @@ -0,0 +1,4 @@ +activeProfiles= +eclipse.preferences.version=1 +resolveWorkspaceProjects=true +version=1 diff --git a/dependencies.md b/dependencies.md index a8fdcba..13475cf 100644 --- a/dependencies.md +++ b/dependencies.md @@ -24,20 +24,20 @@ | ------------------------------------------------------- | -------------------------------- | | [SonarQube Scanner for Maven][12] | [GNU LGPL 3][13] | | [Apache Maven Toolchains Plugin][14] | [Apache License, Version 2.0][5] | -| [Apache Maven Compiler Plugin][15] | [Apache-2.0][5] | -| [Apache Maven Enforcer Plugin][16] | [Apache-2.0][5] | -| [Maven Flatten Plugin][17] | [Apache Software Licenese][5] | -| [org.sonatype.ossindex.maven:ossindex-maven-plugin][18] | [ASL2][19] | -| [Maven Surefire Plugin][20] | [Apache-2.0][5] | -| [Versions Maven Plugin][21] | [Apache License, Version 2.0][5] | -| [duplicate-finder-maven-plugin Maven Mojo][22] | [Apache License 2.0][23] | -| [Apache Maven Assembly Plugin][24] | [Apache-2.0][5] | -| [Apache Maven JAR Plugin][25] | [Apache License, Version 2.0][5] | -| [Artifact reference checker and unifier][26] | [MIT License][27] | -| [JaCoCo :: Maven Plugin][28] | [Eclipse Public License 2.0][29] | -| [error-code-crawler-maven-plugin][30] | [MIT License][31] | -| [Reproducible Build Maven Plugin][32] | [Apache 2.0][19] | -| [Project Keeper Maven plugin][33] | [The MIT License][34] | +| [Project Keeper Maven plugin][15] | [The MIT License][16] | +| [Apache Maven Compiler Plugin][17] | [Apache-2.0][5] | +| [Apache Maven Enforcer Plugin][18] | [Apache-2.0][5] | +| [Maven Flatten Plugin][19] | [Apache Software Licenese][5] | +| [org.sonatype.ossindex.maven:ossindex-maven-plugin][20] | [ASL2][21] | +| [Maven Surefire Plugin][22] | [Apache-2.0][5] | +| [Versions Maven Plugin][23] | [Apache License, Version 2.0][5] | +| [duplicate-finder-maven-plugin Maven Mojo][24] | [Apache License 2.0][25] | +| [Apache Maven Assembly Plugin][26] | [Apache-2.0][5] | +| [Apache Maven JAR Plugin][27] | [Apache License, Version 2.0][5] | +| [Artifact reference checker and unifier][28] | [MIT License][29] | +| [JaCoCo :: Maven Plugin][30] | [Eclipse Public License 2.0][31] | +| [error-code-crawler-maven-plugin][32] | [MIT License][33] | +| [Reproducible Build Maven Plugin][34] | [Apache 2.0][21] | [0]: https://github.com/exasol/virtual-schema-common-jdbc/ [1]: https://github.com/exasol/virtual-schema-common-jdbc/blob/main/LICENSE @@ -54,23 +54,23 @@ [12]: http://sonarsource.github.io/sonar-scanner-maven/ [13]: http://www.gnu.org/licenses/lgpl.txt [14]: https://maven.apache.org/plugins/maven-toolchains-plugin/ -[15]: https://maven.apache.org/plugins/maven-compiler-plugin/ -[16]: https://maven.apache.org/enforcer/maven-enforcer-plugin/ -[17]: https://www.mojohaus.org/flatten-maven-plugin/ -[18]: https://sonatype.github.io/ossindex-maven/maven-plugin/ -[19]: http://www.apache.org/licenses/LICENSE-2.0.txt -[20]: https://maven.apache.org/surefire/maven-surefire-plugin/ -[21]: https://www.mojohaus.org/versions/versions-maven-plugin/ -[22]: https://basepom.github.io/duplicate-finder-maven-plugin -[23]: http://www.apache.org/licenses/LICENSE-2.0.html -[24]: https://maven.apache.org/plugins/maven-assembly-plugin/ -[25]: https://maven.apache.org/plugins/maven-jar-plugin/ -[26]: https://github.com/exasol/artifact-reference-checker-maven-plugin/ -[27]: https://github.com/exasol/artifact-reference-checker-maven-plugin/blob/main/LICENSE -[28]: https://www.jacoco.org/jacoco/trunk/doc/maven.html -[29]: https://www.eclipse.org/legal/epl-2.0/ -[30]: https://github.com/exasol/error-code-crawler-maven-plugin/ -[31]: https://github.com/exasol/error-code-crawler-maven-plugin/blob/main/LICENSE -[32]: http://zlika.github.io/reproducible-build-maven-plugin -[33]: https://github.com/exasol/project-keeper/ -[34]: https://github.com/exasol/project-keeper/blob/main/LICENSE +[15]: https://github.com/exasol/project-keeper/ +[16]: https://github.com/exasol/project-keeper/blob/main/LICENSE +[17]: https://maven.apache.org/plugins/maven-compiler-plugin/ +[18]: https://maven.apache.org/enforcer/maven-enforcer-plugin/ +[19]: https://www.mojohaus.org/flatten-maven-plugin/ +[20]: https://sonatype.github.io/ossindex-maven/maven-plugin/ +[21]: http://www.apache.org/licenses/LICENSE-2.0.txt +[22]: https://maven.apache.org/surefire/maven-surefire-plugin/ +[23]: https://www.mojohaus.org/versions/versions-maven-plugin/ +[24]: https://basepom.github.io/duplicate-finder-maven-plugin +[25]: http://www.apache.org/licenses/LICENSE-2.0.html +[26]: https://maven.apache.org/plugins/maven-assembly-plugin/ +[27]: https://maven.apache.org/plugins/maven-jar-plugin/ +[28]: https://github.com/exasol/artifact-reference-checker-maven-plugin/ +[29]: https://github.com/exasol/artifact-reference-checker-maven-plugin/blob/main/LICENSE +[30]: https://www.jacoco.org/jacoco/trunk/doc/maven.html +[31]: https://www.eclipse.org/legal/epl-2.0/ +[32]: https://github.com/exasol/error-code-crawler-maven-plugin/ +[33]: https://github.com/exasol/error-code-crawler-maven-plugin/blob/main/LICENSE +[34]: http://zlika.github.io/reproducible-build-maven-plugin diff --git a/pom.xml b/pom.xml index a06bf56..959fb12 100644 --- a/pom.xml +++ b/pom.xml @@ -81,6 +81,16 @@ + + org.apache.maven.plugins + maven-compiler-plugin + + + -Xlint:all + -Werror + + + diff --git a/src/test/java/com/exasol/adapter/dialects/impala/ImpalaSqlDialectTest.java b/src/test/java/com/exasol/adapter/dialects/impala/ImpalaSqlDialectTest.java index d742566..690631d 100644 --- a/src/test/java/com/exasol/adapter/dialects/impala/ImpalaSqlDialectTest.java +++ b/src/test/java/com/exasol/adapter/dialects/impala/ImpalaSqlDialectTest.java @@ -8,9 +8,9 @@ import static com.exasol.adapter.capabilities.PredicateCapability.*; import static com.exasol.adapter.capabilities.ScalarFunctionCapability.*; import static org.hamcrest.CoreMatchers.instanceOf; +import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.equalTo; import static org.hamcrest.collection.IsIterableContainingInAnyOrder.containsInAnyOrder; -import static org.hamcrest.MatcherAssert.assertThat; import static org.junit.jupiter.api.Assertions.assertAll; import static org.junit.jupiter.api.Assertions.assertThrows; @@ -21,15 +21,15 @@ import org.hamcrest.Matchers; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.CsvSource; +import org.junit.jupiter.params.provider.ValueSource; import com.exasol.adapter.AdapterProperties; import com.exasol.adapter.capabilities.Capabilities; -import com.exasol.adapter.dialects.PropertyValidationException; import com.exasol.adapter.dialects.SqlDialect; +import com.exasol.adapter.properties.PropertyValidationException; import com.exasol.adapter.sql.ScalarFunction; -import org.junit.jupiter.params.ParameterizedTest; -import org.junit.jupiter.params.provider.CsvSource; -import org.junit.jupiter.params.provider.ValueSource; class ImpalaSqlDialectTest { private ImpalaSqlDialect dialect; From 3e4f724b89f0294c9c87fba452ccdda9ade65458 Mon Sep 17 00:00:00 2001 From: ckunki Date: Mon, 18 Mar 2024 11:44:39 +0100 Subject: [PATCH 3/4] Fixed review findings --- .gitignore | 6 +++++- .settings/org.eclipse.core.resources.prefs | 6 ------ .settings/org.eclipse.m2e.core.prefs | 4 ---- 3 files changed, 5 insertions(+), 11 deletions(-) delete mode 100644 .settings/org.eclipse.core.resources.prefs delete mode 100644 .settings/org.eclipse.m2e.core.prefs diff --git a/.gitignore b/.gitignore index e443959..a3ddd22 100644 --- a/.gitignore +++ b/.gitignore @@ -3,7 +3,11 @@ # Eclipse and Maven .classpath .project -# .settings : we need Eclipse settings for code formatter and clean-up rules +/.settings/org.eclipse.core.resources.prefs +/.settings/org.eclipse.jdt.apt.core.prefs +/.settings/org.eclipse.m2e.core.prefs +/.settings/org.moreunit.prefs +/.settings/org.sonarlint.eclipse.core.prefs target .cache dependency-reduced-pom.xml diff --git a/.settings/org.eclipse.core.resources.prefs b/.settings/org.eclipse.core.resources.prefs deleted file mode 100644 index 29abf99..0000000 --- a/.settings/org.eclipse.core.resources.prefs +++ /dev/null @@ -1,6 +0,0 @@ -eclipse.preferences.version=1 -encoding//src/main/java=UTF-8 -encoding//src/main/resources=UTF-8 -encoding//src/test/java=UTF-8 -encoding//src/test/resources=UTF-8 -encoding/=UTF-8 diff --git a/.settings/org.eclipse.m2e.core.prefs b/.settings/org.eclipse.m2e.core.prefs deleted file mode 100644 index f897a7f..0000000 --- a/.settings/org.eclipse.m2e.core.prefs +++ /dev/null @@ -1,4 +0,0 @@ -activeProfiles= -eclipse.preferences.version=1 -resolveWorkspaceProjects=true -version=1 From ba51a98f8cc4f539e336d38fa3c2c056bed14e8e Mon Sep 17 00:00:00 2001 From: Christoph Kuhnke Date: Mon, 18 Mar 2024 11:45:01 +0100 Subject: [PATCH 4/4] Update doc/changes/changes_2.0.1.md Co-authored-by: Christoph Pirkl --- doc/changes/changes_2.0.1.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/changes/changes_2.0.1.md b/doc/changes/changes_2.0.1.md index 6910006..93f26e1 100644 --- a/doc/changes/changes_2.0.1.md +++ b/doc/changes/changes_2.0.1.md @@ -6,7 +6,7 @@ Code name: ## Documentation -* #18: Updated link to claudera impala page and dependencies +* #18: Updated link to Cloudera Impala page and dependencies ## Dependency Updates