Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSMYSQL CREATE ADAPTER SCRIPT in User Guide #36

Closed
allipatev opened this issue May 24, 2023 · 4 comments · Fixed by #41
Closed

VSMYSQL CREATE ADAPTER SCRIPT in User Guide #36

allipatev opened this issue May 24, 2023 · 4 comments · Fixed by #41
Assignees
Labels
documentation User guides, tutorials, specifications

Comments

@allipatev
Copy link

Customer had a problem because of --/ before the line

CREATE OR REPLACE JAVA ADAPTER SCRIPT SCHEMA_FOR_VS_SCRIPT.ADAPTER_SCRIPT_MYSQL AS

as SQL clients other then DB Visualizer might find the script body to send to DB incorrectly in this case.

Please consider adding a remark to the User guide that the comment ('--/') will is ONLY necessary for a DB Visualizer SQL client and not for others.

@kaklakariada kaklakariada added the documentation User guides, tutorials, specifications label Jun 14, 2023
@ckunki
Copy link
Contributor

ckunki commented Aug 15, 2023

Already solved with #26

@ckunki
Copy link
Contributor

ckunki commented Aug 16, 2023

Hello @allipatev sorry I misread the current ticket.

@ckunki ckunki reopened this Aug 16, 2023
@ckunki
Copy link
Contributor

ckunki commented Aug 17, 2023

Hello @allipatev I also checked the official documentation at docs.exasol.com and noticed

Currently in in VSMYSQL user guide the line before the CREATE ADAPTER is a comment and should be ignored by SQL clients AFAIK.
I also checked the script with SQL Client DBeaver without any problems which means for DBeaver the first line is not required but also not harmful.

If possible I also would prefer to keep the documentation as simple and straight-forward as possible, i.e. avoid if-then cases describing different scenarios whenever possible.

Would it be acceptable in your eyes if VSMYSQL user guide would use the same phrasing as the official documentation?

@ckunki ckunki changed the title CREATE ADAPTER SCRIPT in User Guide VSMYSQL CREATE ADAPTER SCRIPT in User Guide Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation User guides, tutorials, specifications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants