Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sonar code smells #27

Closed
redcatbear opened this issue Feb 19, 2019 · 0 comments · Fixed by #86
Closed

Fix Sonar code smells #27

redcatbear opened this issue Feb 19, 2019 · 0 comments · Fixed by #86
Assignees
@AnastasiiaSergienko
Labels
refactoring Code improvement without behavior change

Comments

@redcatbear
Copy link
Collaborator

redcatbear commented Feb 19, 2019 •
edited
Loading

Fix the code smells Sonar found in the development version 0.3.0.
redcatbear added a commit that referenced this issue Feb 19, 2019
@redcatbear
#27: Fixed Sonar findings.
d0418d4
redcatbear added a commit that referenced this issue Feb 19, 2019
@redcatbear
#27: Added test coverage.
6bed408
redcatbear added a commit that referenced this issue Feb 22, 2019
@redcatbear
Bugfix/27 fix sonar findings on 0.3.0 (#31)
e10d11d 
* #12: Prepared signing.

* #12: Updated version number to 0.3.0

* #12: Removed GPG signing execution.

* #12: Removed Travis CI run with Java 11 because of JavaDoc incompatibilities (see #19).

* Update README.md

* Update README.md

* #23: Added Sonar checks and badges. (#26)

* #23: Added Sonar checks and badges.
* #23: Updated Surefire plugin version to 3.0.0-M3.
* #23: Added Jacoco plugin.

* #12: Added support for value tables. Adapted dependent code. (#22)

* #12: Added support for value tables.

* #27: Fixed Sonar findings.

* #27: Added test coverage.
redcatbear added a commit that referenced this issue Feb 25, 2019
@redcatbear
#27: Fixed Sonar findings. (#28)
67ac3cf 
* #27: Fixed Sonar findings on 0.3.0.
redcatbear added a commit that referenced this issue Feb 25, 2019
@redcatbear
#27: Extracted ValueTableVisitor interface.
fcdeb03
redcatbear added a commit that referenced this issue Feb 25, 2019
@redcatbear
#27: Removed throws declarations for runtime exceptions.
d2c05a7
redcatbear added a commit that referenced this issue Feb 25, 2019
@redcatbear
Coverage: Fixed sonar findings in 0.3.0 (#33)
f67658a 
* #12: Prepared signing.

* #12: Updated version number to 0.3.0

* #12: Removed GPG signing execution.

* #12: Removed Travis CI run with Java 11 because of JavaDoc incompatibilities (see #19).

* Update README.md

* Update README.md

* #23: Added Sonar checks and badges. (#26)

* #23: Added Sonar checks and badges.
* #23: Updated Surefire plugin version to 3.0.0-M3.
* #23: Added Jacoco plugin.

* #12: Added support for value tables. Adapted dependent code. (#22)

* #12: Added support for value tables.

* #27: Fixed Sonar findings. (#28)

* #27: Fixed Sonar findings on 0.3.0.
redcatbear added a commit that referenced this issue Feb 25, 2019
@redcatbear
#27: Made root reference private and final.
cc62409
redcatbear added a commit that referenced this issue Feb 25, 2019
@redcatbear
Bugfix/27 fix sonar findings on 0.3.0 (#32)
3777dde 
* #27: Fixed Sonar findings.
redcatbear added a commit that referenced this issue Feb 25, 2019
@redcatbear
#27: Decoupled value table specific methods from generic fragment int…
67a5a73 
…erface.
redcatbear added a commit that referenced this issue Feb 25, 2019
@redcatbear
Bugfix/27 fix sonar findings on 0.3.0 (#34)
c1ee174 
* #27: Fixed Sonar findings.
AnastasiiaSergienko added a commit that referenced this issue Mar 29, 2019
@AnastasiiaSergienko
Merge develop into master (#39)
b86bba0 
* #12: Removed GPG signing execution.
* #12: Removed Travis CI run with Java 11 because of JavaDoc incompatibilities (see #19).
* #12: Added support for value tables. Adapted dependent code. (#22)
* #23: Added Sonar checks and badges. (#26)
* #27: Fixed Sonar findings. (#28)
* #29: Implemented 'CREATE TABLE'.
* #36: wrote CREATE TABLE part of the users guide.
@AnastasiiaSergienko AnastasiiaSergienko added the refactoring Code improvement without behavior change label Jul 2, 2020
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Jul 2, 2020
AnastasiiaSergienko added a commit that referenced this issue Jul 6, 2020
@AnastasiiaSergienko
#27: fixed sonar findings
37ec803
AnastasiiaSergienko added a commit that referenced this issue Jul 6, 2020
@AnastasiiaSergienko
#27: removed unnecessary suppress warning
b261ac8
@AnastasiiaSergienko AnastasiiaSergienko mentioned this issue Jul 6, 2020
Merged
AnastasiiaSergienko added a commit that referenced this issue Jul 6, 2020
@AnastasiiaSergienko
#27: fixed sonar findings (#86)
e28937c 
* #27: fixed sonar findings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnastasiiaSergienko AnastasiiaSergienko

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#27: fixed sonar findings exasol/sql-statement-builder
2 participants
@redcatbear @AnastasiiaSergienko