Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure project-keeper to include javascript-tests #66

Closed
kaklakariada opened this issue Mar 13, 2023 · 0 comments · Fixed by #68
Closed

Configure project-keeper to include javascript-tests #66

kaklakariada opened this issue Mar 13, 2023 · 0 comments · Fixed by #68
Assignees
@redcatbear @kaklakariada
Labels
refactoring Code improvement without behavior change

Comments

@kaklakariada
Copy link
Collaborator

File javascript-test/package.json from the latest git tag does not contain name and version attributes. Project keeper reads the file from the previous tag in order to determine which dependencies have changed.

After the missing attributes where added we need to create a release and add the following lines to .project-keeper.yml:

  - type: npm
    path: javascript-test/package.json
@kaklakariada kaklakariada added refactoring Code improvement without behavior change blocked:yes Currently blocked by another ticket labels Mar 13, 2023
@kaklakariada kaklakariada mentioned this issue Mar 13, 2023
Merged
@kaklakariada kaklakariada self-assigned this Mar 14, 2023
kaklakariada added a commit that referenced this issue Mar 14, 2023
@kaklakariada
#66: Configure javascript test module for Project Keeper
2221090
@kaklakariada kaklakariada mentioned this issue Mar 14, 2023
Merged
@redcatbear redcatbear self-assigned this Mar 14, 2023
kaklakariada added a commit that referenced this issue Mar 14, 2023
@kaklakariada
#66: Configure project keeper (#68)
0362758 
* #66: Configure javascript test module for Project Keeper

* Run PK fix
@ckunki ckunki removed the blocked:yes Currently blocked by another ticket label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redcatbear redcatbear

@kaklakariada kaklakariada

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#66: Configure project keeper exasol/tableau-connector
3 participants
@redcatbear @kaklakariada @ckunki