#43 TLS fingerprint support for ODBC #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobbraun
suggested changes
Feb 2, 2022
doc/changes/changes_0.5.0.md
Outdated
| @@ -1,13 +1,15 @@ | |||
| # Exasol Tableau Connector 0.5.0, released 2022-02-?? | |||
There was a problem hiding this comment.
Thanks for the reminder 😅
Comment on lines
+345
to
+347
| 4. [Create a new GitHub release](https://github.com/exasol/tableau-connector/releases/new) and upload files | ||
| * `target/tableau-exasol-connector-jdbc-<version>.taco` | ||
| * `target/tableau-exasol-connector-odbc-<version>.taco` |
There was a problem hiding this comment.
Maybe you can automate this with release droid?
There was a problem hiding this comment.
The release requires signing the connector. I will clarify if we can use the certificate in a GitHub build.
| @@ -5,7 +5,7 @@ | |||
| <connection class='federated'> | |||
| <named-connections> | |||
| <named-connection name='leaf'> | |||
| <connection tdvtconnection='exasol_odbctestname' class='exasol_odbc' odbc-connect-string-extras='' port='8563' schema='TESTV1' server='exasol.test.lan/15F9CA9BC95E14F1F913FC449A26723841C118CFB644957866ABB73C1399A7FF' tablename='Staples' username='TABLEAU_TEST_USER' /> | |||
| <connection tdvtconnection='exasol_odbctestname' class='exasol_odbc' odbc-connect-string-extras='' port='8563' schema='TESTV1' server='exasol.test.lan' tablename='Staples' username='TABLEAU_TEST_USER' v-fingerprint='15F9CA9BC95E14F1F913FC449A26723841C118CFB644957866ABB73C1399A7FF' /> | |||
There was a problem hiding this comment.
Is it intended to commit the fingerprint here?
There was a problem hiding this comment.
Yes. The test framework requires configuring the DB connection here. As long as we can only run the tests manually it doesn't make sense to extract this.
| @@ -5,7 +5,7 @@ | |||
| <connection class='federated'> | |||
| <named-connections> | |||
| <named-connection name='leaf'> | |||
| <connection tdvtconnection='exasol_odbctestname' class='exasol_odbc' odbc-connect-string-extras='' port='8563' schema='TESTV1' server='exasol.test.lan/15F9CA9BC95E14F1F913FC449A26723841C118CFB644957866ABB73C1399A7FF' tablename='Calcs' username='TABLEAU_TEST_USER' /> | |||
| <connection tdvtconnection='exasol_odbctestname' class='exasol_odbc' odbc-connect-string-extras='' port='8563' schema='TESTV1' server='exasol.test.lan' tablename='Calcs' username='TABLEAU_TEST_USER' v-fingerprint='15F9CA9BC95E14F1F913FC449A26723841C118CFB644957866ABB73C1399A7FF' /> | |||
There was a problem hiding this comment.
Is it intended to commit the fingerprint here?
There was a problem hiding this comment.
Yes, see previous comment.
Co-authored-by: jakobbraun <[email protected]>
jakobbraun
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43