Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit initialization to AdapterFactory #116

Closed
redcatbear opened this issue Oct 31, 2019 · 0 comments · Fixed by #117
Closed

Add explicit initialization to AdapterFactory #116

redcatbear opened this issue Oct 31, 2019 · 0 comments · Fixed by #117
Assignees

Comments

@redcatbear
Copy link
Collaborator

Situation

When an AdapterFactory implementation is instantiated, not all aspects are necessarily hard-coded. For example the JdbcAdapterFactory must use the ServiceLoader in order to find out which SQL dialects it supports.

To avoid any chicken-of-the-egg problems, we add a new initialization method to the AdapterFactory that is guaranteed to be called before any of the other methods in that interface.

@redcatbear redcatbear self-assigned this Oct 31, 2019
redcatbear added a commit that referenced this issue Nov 13, 2019
…AdapterFactory

#116: Initializing adapter registry on first use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant