Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent from unhandled promise rejection durning workbook load #1087

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Prevent from unhandled promise rejection durning workbook load #1087

merged 1 commit into from
Jan 21, 2020

Conversation

sohai
Copy link

@sohai sohai commented Jan 21, 2020

Since #829 StreamBuf.write returns Promise, that leads to unhandled promise rejection in Workbook.load because ZipStream.writedo not expect StreamBuf.write to return Promise.

@alubbe alubbe merged commit 020cb99 into exceljs:master Jan 21, 2020
@alubbe
Copy link
Member

alubbe commented Jan 21, 2020

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

@alubbe alubbe alubbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sohai @alubbe @Siemienik