-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile Page: completed exercises chart #2816
Comments
Copying my response from the other thread: Yeah, I'm all for making a change like this, both in terms of moving or downplaying the progress bars, as well as including how many problems the person has reviewed. Let's do the thing where we show you the icon + completed problems + peer reviewed problems, and then if you hover over it (or click?) you get more information. I'm not married to the progress bar, it's an experiment in giving more information. If a grid of the language icons with numbers gives a better impression, we can drop the progress bars altogether. |
@kytrinyx I'll be happy to remove the progress bar in favor to of number of total and completed and adding the total reviewed problems |
@GustavoCaso that sounds great! |
@kytrinyx here a draft without style, but wanted to check first, to see your impressions This approach is assuming that an user can not comment on exercises which track has not been started. I was thinking on adding a tooltip for showing the total number of problems in each track |
There are several people who do code reviews without completing exercises. We have a setting on the user record that gives people "mentor" status on a track, where they can see everything without having done the exercises. What do you think of something like this: [icon] Language Name Or maybe: I worry that the language around how many you've peer reviewed will be confusing, because you might have done thousands of reviews on three different problems and it will say 3 not 2876 (or whatever). I don't know what the right answer to that is. Maybe we need to have both numbers (but is that going to be messy? A performance problem?) [icon] Language Name What would it look like if we took the basic style from the activity stream? |
@kytrinyx With performance in the initial approach I took the completed exercises from About the design yes following the activity stream style might be a good idea. |
@kytrinyx do you like this style ? the reviewed section show the total but is missing the information related with how many exercises you have reviewed, but I just wanted to check if you like where this is going ? or we should rethink |
I think the style works well. It's pretty easy to scan. |
if Completed == 1 then "1 Problem" else " |
@masters3d good call. I think active support has something that does this for English - http://api.rubyonrails.org/classes/ActiveSupport/Inflector.html#method-i-pluralize So:
|
It does @kytrinyx |
On Mon, Sep 19, 2016 at 1:01 PM, Gustavo Caso [email protected]
Check out this section: |
@kytrinyx thanks 👍 |
@kytrinyx I think we can close this one. |
Yepp, agreed. Thanks! |
I love the profile page but I am not a fan of the percentage of completion as the first thing that gets seen.
Humans are kinna of prideful creatures. A profile is something I'd like to show my friends when we are having coffee.
The percentage of completion makes it feel to me that I have not finished something or that I am falling.
I much rather have a page that shows me *how many * problems I've completed and maybe if I click or hover over the language I can get a percentage but the percentage should not be the first thing I see when go to my page.
Perhaps it can be something like this and also include how many problems I have nitpicked from each language?
// Something along these lines
Swift
35 Completed Problems
45 Peer Reviewed Problems
Cross posted:
exercism/problem-specifications#218 (comment)
The text was updated successfully, but these errors were encountered: