Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: a custom name instead of req.session #149

Open
lukaszmakuch opened this issue Jan 31, 2021 · 2 comments
Open

Suggestion: a custom name instead of req.session #149

lukaszmakuch opened this issue Jan 31, 2021 · 2 comments

Comments

@lukaszmakuch
Copy link

Hello! 👋

Thank you for this package!

I'm considering contributing some code.

In a project I'm working on I'd like to utilize two separate sessions with different SameSite settings for the same endpoint.

If I understand correctly, it's not possible at the moment due to req.session and req.sessionOptions not being customizable.

Would a PR be welcomed?

@jardakotesovec
Copy link

@lukaszmakuch I am not involved in this particular project, but definitely would appreciate such flexibility for 'multiple sessions' setup..
@dougwilson What you think? Would you be willing to accept such MR from @lukaszmakuch ?

@juditgreskovits
Copy link

@dougwilson and @Ostefanini
We also could make use of functionality to allow multiple cookie session middleware instances.
Would you welcome (and review) a PR from us? If so, do you have any particular expectations around the approach to take?
Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants