-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: 코드 컨벤션 체크 #6
Labels
Comments
This was referenced Jul 7, 2023
Closed
Closed
Local dev env에선 동작하게끔 했습니다만, Github Action에서 ktlint workflow 파일이 PR시마다 안 돌아가는 이유를 모르겠습니다. 리뷰바람. |
klint-actions에서는 성공했다고 뜹니다. #11 PR을 제가 닫았기때문에, 해당 브랜치가 main으로 합쳐지지 않았고, 그렇기 때문에 모든 PR마다 안돌아갑니다. commit template 준수해서 다시 올려주세요. 자연스럽게 해당 action이 모든 PR마다 돌아갈겁니다. |
jobs 중 reviewdog: This GitHub token doesn't have write permission of Review API [1],
reviewdog: Reporting results for "ktlint"
so reviewdog will report results via logging command [2] and create annotations similar to
github-pr-check reporter as a fallback.
[1]: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target,
[2]: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#logging-commands
reviewdog: No results found for "ktlint". 34 results found outside diff. |
assigned @junha-ahn |
closed by #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
코드 컨벤션 체크를 위한 툴을 적용해주세요 (린트, 컨벤션 체크)
To do
Test Checklist
The text was updated successfully, but these errors were encountered: