Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested lists with 2+ levels #165

Open
andreferreirav2 opened this issue Jan 2, 2019 · 9 comments
Open

Nested lists with 2+ levels #165

andreferreirav2 opened this issue Jan 2, 2019 · 9 comments
Labels
bug Something isn't working
Milestone

Comments

@andreferreirav2
Copy link

andreferreirav2 commented Jan 2, 2019

When creating lists with more than 2 levels, the 3rd level turns red and there is no actual change in the preview.

In order to create a 3rd level I need to add 3 tabs instead of 1.
Plus, there is a weird extra line spacing between the 1st and 2nd levels.

Ex:
screenshot 2019-01-02 12 57 23

Results in:
screenshot 2019-01-02 12 53 44

@fabiospampinato fabiospampinato added the bug Something isn't working label Jan 2, 2019
@fabiospampinato
Copy link
Member

Sounds like a bug with CodeMirror itself or maybe one of its plugins 🤔

@fabiospampinato fabiospampinato added the help wanted Some help is needed and/or PRs are welcome label Jan 3, 2019
@fabiospampinato fabiospampinato added this to the Next milestone Jan 24, 2019
@fabiospampinato
Copy link
Member

This will probably get fixed once we switch to Monaco #203

@fabiospampinato fabiospampinato removed the help wanted Some help is needed and/or PRs are welcome label Jan 29, 2019
@fabiospampinato
Copy link
Member

I think there are 2 issues here actually:

When creating lists with more than 2 levels, the 3rd level turns red

This is a problem with CodeMirror, and it will probably get fixed when we switch to Monaco #203.

In order to create a 3rd level I need to add 3 tabs instead of 1.

This is a bug with showdown: showdownjs/showdown#367

@fabiospampinato fabiospampinato modified the milestones: Next, Future Feb 22, 2019
@fabiospampinato
Copy link
Member

When creating lists with more than 2 levels, the 3rd level turns red and there is no actual change in the preview.

We just switched to Monaco #203 and this is no longer a problem.

The bug about the rendering is still present though.

@kyldvs
Copy link

kyldvs commented Mar 28, 2019

Running into the same issues with lists not being indented properly

Screenshot (265)

@wh0am1-dev
Copy link

wh0am1-dev commented Apr 2, 2019

If you use 4 spaces indentation instead of 2 spaces, it renders properly. 🎉
It is not consistent with the editor inserting 2 spaces on tab, though.

@fabiospampinato
Copy link
Member

@neko250 yeah, turned out our Markdown processor doesn't support 2-space indented lists. This will get fixed once we switch to marked #531

@fabiospampinato
Copy link
Member

Fixed in v1.6.

But ordered lists indented this way are not supported by CommonMark, for some reason that really makes no sense to me, I'll probably get this fixed too in a later release. commonmark/commonmark-spec#594

@fabiospampinato
Copy link
Member

Reopening as some patching of the Markdown compiler is required to make this work for ordered lists too.

@fabiospampinato fabiospampinato modified the milestones: Future, Next Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

4 participants