From 856a3ec7bc67691a57994bee455842aeb57dfc9a Mon Sep 17 00:00:00 2001 From: Tarkan Al-Kazily Date: Fri, 17 Jan 2025 18:39:16 -0800 Subject: [PATCH] Simplify helper functions in constraint_overrides.bzl Summary: Make `_platforms()` and `_constraints()` implementation match `_passthrough_constraints_val`. Reviewed By: gabagam Differential Revision: D68295735 fbshipit-source-id: a5a2f465855688d739b536288382b8de25498650 --- transitions/constraint_overrides.bzl | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/transitions/constraint_overrides.bzl b/transitions/constraint_overrides.bzl index 8d8fbb62c..dfb7629c7 100644 --- a/transitions/constraint_overrides.bzl +++ b/transitions/constraint_overrides.bzl @@ -13,23 +13,15 @@ # - buck2.constraints # - buck2.passthrough_constraints +_platforms_val = read_root_config("buck2", "platforms", "") +_constraints_val = read_root_config("buck2", "constraints", "") +_passthrough_constraints_val = read_root_config("buck2", "passthrough_constraints", "") + def _platforms() -> list[str]: - platforms = [] - config = read_root_config("buck2", "platforms", "") - platforms.extend( - [platform.strip() for platform in config.split(",") if platform.strip()], - ) - return platforms + return [platform.strip() for platform in _platforms_val.split(",") if platform.strip()] def _constraints() -> list[str]: - constraints = [] - config = read_root_config("buck2", "constraints", "") - constraints.extend( - [constraint.strip() for constraint in config.split(",") if constraint.strip()], - ) - return constraints - -_passthrough_constraints_val = read_root_config("buck2", "passthrough_constraints", "") + return [constraint.strip() for constraint in _constraints_val.split(",") if constraint.strip()] def _passthrough_constraints() -> list[str]: return [constraint.strip() for constraint in _passthrough_constraints_val.split(",") if constraint.strip()]