-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote persistent worker support #787
base: main
Are you sure you want to change the base?
Commits on Oct 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a62ed89 - Browse repository at this point
Copy the full SHA a62ed89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 003b58d - Browse repository at this point
Copy the full SHA 003b58dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d4f1ea - Browse repository at this point
Copy the full SHA 0d4f1eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 872064c - Browse repository at this point
Copy the full SHA 872064cView commit details -
Use WorkerRunInfo.exe for non-worker mode
`WorkerRunInfo` has two fields `worker` and `exe` for the persistent worker command or the non-worker mode command respectively. This commit changes the remote persistent worker example to use these appropriately to distinguish between worker and non-worker mode execution.
Configuration menu - View commit details
-
Copy full SHA for 386ee26 - Browse repository at this point
Copy the full SHA 386ee26View commit details -
Use WorkerRunInfo.worker for remote persistent worker
The Buck2 Rust implementation needs to use the worker command instead of the non-worker command for remote persistent worker execution mode.
Configuration menu - View commit details
-
Copy full SHA for dbb8d6a - Browse repository at this point
Copy the full SHA dbb8d6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e448e0 - Browse repository at this point
Copy the full SHA 2e448e0View commit details -
Create proto_python_library rule
We want to use a Buck2 managed hermetic Python toolchain. However, Python binaries generated by such a toolchain are sensitive to `PWD` and don't work in other working directories than the repository root. Unfortunately, `genrule` changes directory and is hence incompatible with such Python binaries. This commit defines a dedicated rule to invoke protoc without changing the working directory.
Configuration menu - View commit details
-
Copy full SHA for e427c7a - Browse repository at this point
Copy the full SHA e427c7aView commit details -
Hermetic Python toolchain and Buck2 installed packages
The previous setup used Nix to provide a Python toolchain and packages in a reproducible fashion. However, this requires dedicated remote worker images with the Nix store paths pre-populated which complicates the setup for testing on Buck2 CI. Using a hermetic Python toolchain avoids these issues and works on the standard remote execution image.
Configuration menu - View commit details
-
Copy full SHA for 5f98607 - Browse repository at this point
Copy the full SHA 5f98607View commit details -
Remove the old genrule targets to generate the Python gRPC/protobuf bindings.
Configuration menu - View commit details
-
Copy full SHA for 9890623 - Browse repository at this point
Copy the full SHA 9890623View commit details -
Standard BuildBuddy worker image
Without Nix it is no longer required to use a custom remote worker image.
Configuration menu - View commit details
-
Copy full SHA for cc593fa - Browse repository at this point
Copy the full SHA cc593faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a7d45d - Browse repository at this point
Copy the full SHA 7a7d45dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4e6667 - Browse repository at this point
Copy the full SHA e4e6667View commit details -
It's useful to test multiple builds in parallel to catch potential issues related parallel worker requests. However, we also don't need to be excessive in the number of tests to not unnecessarily waste resources.
Configuration menu - View commit details
-
Copy full SHA for b4376e9 - Browse repository at this point
Copy the full SHA b4376e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88a399a - Browse repository at this point
Copy the full SHA 88a399aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f88885 - Browse repository at this point
Copy the full SHA 3f88885View commit details -
Test persistent worker example on CI
Requires a repository secret to be set up for the BuildBuddy API key named `BUILDBUDDY_API_KEY`.
Configuration menu - View commit details
-
Copy full SHA for 0a7f496 - Browse repository at this point
Copy the full SHA 0a7f496View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d9b7cb - Browse repository at this point
Copy the full SHA 5d9b7cbView commit details
Commits on Oct 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 722d948 - Browse repository at this point
Copy the full SHA 722d948View commit details -
Configuration menu - View commit details
-
Copy full SHA for e503285 - Browse repository at this point
Copy the full SHA e503285View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ea6a03 - Browse repository at this point
Copy the full SHA 3ea6a03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cf252e - Browse repository at this point
Copy the full SHA 6cf252eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7181c3d - Browse repository at this point
Copy the full SHA 7181c3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62b3f8a - Browse repository at this point
Copy the full SHA 62b3f8aView commit details