Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use webpack.NamedModulesPlugin in dev #2448

Closed
sophiebits opened this issue Jun 1, 2017 · 7 comments
Closed

Use webpack.NamedModulesPlugin in dev #2448

sophiebits opened this issue Jun 1, 2017 · 7 comments
Labels
contributions: claimed difficulty: starter tag: enhancement
Milestone
1.0.8

Comments

@sophiebits
Copy link
Contributor

Can we use webpack.NamedModulesPlugin in development mode? Apparently it will make module factory names show up correctly in the devtools (see webpack/webpack#4858).
@gaearon
Copy link
Contributor

gaearon commented Jun 1, 2017

Sounds good! I didn't realize. Want to send a PR?

@Timer
Copy link
Contributor

Timer commented Jun 1, 2017

I would love to see this done alongside #2328 (since it introduces this plugin anyway).

@sophiebits
Copy link
Contributor Author

This can probably be done independently of #2328 too, but I'm happy to have someone new take a stab at this and verify that it works.

@gaearon gaearon added this to the 1.x milestone Jun 2, 2017
@Zaccc123 Zaccc123 mentioned this issue Jun 2, 2017
Merged
@Zaccc123
Copy link
Contributor

Zaccc123 commented Jun 2, 2017

I updated it locally and generate a new app to test, the profile in startup does look better:
updated-profiler

@sophiebits
Copy link
Contributor Author

Looks awesome.

@gaearon gaearon modified the milestones: 1.0.8, 1.x Jun 6, 2017
@gaearon
Copy link
Contributor

gaearon commented Jun 6, 2017

Fixed in #2458.
Sorry for slow review—some React stuff has been taking my time 😛

@gaearon gaearon closed this as completed Jun 6, 2017
@gaearon
Copy link
Contributor

gaearon commented Jun 28, 2017

Fixed in 1.0.8. Please verify.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.0.8

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributions: claimed difficulty: starter tag: enhancement
Projects
None yet
Milestone
1.0.8
Development

No branches or pull requests
4 participants
@sophiebits @Timer @gaearon @Zaccc123