Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide empty mock for dgram module #2584

Closed
micopiira opened this issue Jun 21, 2017 · 3 comments
Closed

Provide empty mock for dgram module #2584

micopiira opened this issue Jun 21, 2017 · 3 comments
Milestone

Comments

@micopiira
Copy link
Contributor

micopiira commented Jun 21, 2017

dgram is an node module that provides an implementation of UDP Datagram sockets.

I'm using a package that depends on dgram, but does not need it for the most part. Providing an empty mock for dgram; just like there are empty mocks for fs, net and tls modules would save me from ejecting like in #672.

This should be as simple as adding line: dgram: 'empty' (NOTE: I have not tested this yet!) to the webpack configuration files, I can also provide a PR if you want.

@gaearon
Copy link
Contributor

gaearon commented Jun 22, 2017

I feel okay taking a PR like this.

@micopiira
Copy link
Contributor Author

#2600 here is the PR

@gaearon gaearon added this to the 1.0.8 milestone Jun 26, 2017
@gaearon
Copy link
Contributor

gaearon commented Jun 26, 2017

Fixed by #2600.

@gaearon gaearon closed this as completed Jun 26, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants