Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add create-react-app --info #3380

Closed
tabrindle opened this issue Oct 31, 2017 · 5 comments
Closed

add create-react-app --info #3380

tabrindle opened this issue Oct 31, 2017 · 5 comments

Comments

@tabrindle
Copy link
Contributor

This issue template seems to reserve a lot of space for trying to replicate and lock down issues from differing environments. Generally we want to make the process easier to ensure we get quality bug reports, so if the maintainers of the project agree, I'd like to integrate my envinfo package into CRA, the same way I already have for react-native.

Something like this:

create-react-app --info in a project will yield something like this:

Environment:
  OS:  macOS Sierra 10.12.4
  Node:  v7.10.0
  Yarn:  0.24.5
  npm:  4.2.0
Packages:
  react:  16.0.0-alpha.6
  jest:  ^20.0.4
  eslint:  ^3.19.0
  babel-polyfill:  ^6.23.0

I can add/subtract things from this report, and even nifty things like add auto add to clipboard.

Thoughts?

@bondz
Copy link
Contributor

bondz commented Nov 1, 2017

This would help with the environment section of the issue template

### Environment

<!--
  Please fill in all the relevant fields by running these commands in terminal.
-->

1. `node -v`: 
2. `npm -v`:
3. `yarn --version` (if you use Yarn):
4. `npm ls react-scripts` (if you haven’t ejected): 

Then, specify:

1. Operating system:
2. Browser and version (if relevant):

But would require an update to CRA itself to work.

@tabrindle
Copy link
Contributor Author

Indeed - react native already has similar and it has worked amazingly well - you can see it in action in their issues. They even have a bot to auto close issues missing the template and environment.

The only additional thing they would have to add is browser+version.

react-native had the same issue where it was only available starting on version 0.48, but it was a good reason to get people to upgrade, and frequently solved their problem before even fully reporting the issue.

If we believe it's worth it, I will make 2 PRs - one to add the CLI command, then another to add the updated instructions to the issue template, once the first PR is merged and there has been some time to update.

@bondz
Copy link
Contributor

bondz commented Nov 3, 2017

Personally, I like it.

Also #3385 seems to be going the direction of adding a flag like this one.

cc @Timer

@tabrindle
Copy link
Contributor Author

I have a PR for the change to the CLI - #3408. I think we close this issue once that and my changes to the issue template get merged.

@tabrindle
Copy link
Contributor Author

I think its safe to close this issue now - both the implementation and docs are merged!
Thanks guys!

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants