Rest properties are broken with Jest + node v6

[vinhlh]

Is this a bug report?

Might be

Environment

• node v6.12.3
• react-scripts v1.0.17

Steps to Reproduce

Add this test

it('run without crashing', () => {
  const arrayOfObjects = [{ awesome: true }]
  const [{ awesome, ...rest}] = arrayOfObjects

  expect(true).toBe(true)
});

Expected Behavior

No error

Actual Behavior

      const [{ awesome, ...rest }] = arrayOfObjects;
                        ^^^

    SyntaxError: Unexpected token ...

[miraage]

Either update Node to 8.9+ or only use syntax supported by your Node version since no transformations being run against your tests code.

Node versions manager to consider:
https://github.com/creationix/nvm (I personally prefer this)
https://github.com/tj/n

[Timer]

Sounds like a bug to me; maybe we need to bump the version of babel-preset-env or make sure this transform is included during tests?

[miraage]

@vinhlh looks like I misunderstood your question. Is your test file located outside src directory?
AFAIK babel only applies to files inside src.

[werne2j]

@Timer i'd like to take this issue if no one else has. This issue happens even if the test is inside the src directory.

[Timer]

All yours, @werne2j! Let me know your findings. 😄

[werne2j]

@Timer i may need some help with this issue. To me, it looks like the issue is in
react-scripts/scripts/util/createJestConfig.js involving the testMatch.
When i revert the test match to what it was before this commit
5c8000f#diff-40a56a7d41499eab85303b5e977f9742
the tests seem to work fine.

Not sure if that is the actual issue but thats what i have seen so far

[Timer]

That sounds odd @werne2j, what would a test match have to do with syntax features? 🤔

[werne2j]

@Timer it shouldn't have anything to do with it. Thinking about it, i'm sure that is not the issue but i can't seem to figure out what the real issue is

[gaearon]

Confirmed I reproduce this on master.

[gaearon]

Can reproduce on next too.

[gaearon]

This looks like babel/babel#7099 to me.

[gaearon]

Pushing this back to 2.x since it's a legit Babel bug and probably not fixable on our side. We'll need to wait for it to get resolved upstream.

[gaearon]

Apparently we can work around this by always including the destructuring transform.
Here's why: babel/babel#7215 (comment)

[Timer]

Fixed via #3788

[gaearon]

Just ported to next, hopefully it works

[werne2j]

I thought I tried this but I must not have been testing it correctly. Glad you were able to get it working @gaearon! Thanks for the help!

[gaearon]

No problem, thanks for trying!

[gaearon]

This is out in [email protected]! Please let us know if something doesn’t quite work.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.1.0