Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve Licenses #4116

Closed
jzacharuk opened this issue Mar 6, 2018 · 4 comments
Closed

Preserve Licenses #4116

jzacharuk opened this issue Mar 6, 2018 · 4 comments

Comments

@jzacharuk
Copy link

Is there an option to preserve licenses of node_modules while using npm run build?

It's my understanding that even permissive licenses such as MIT require a copy of the license/copyright notice. By using the react-scripts build and deploying the output to a server it seems that requirement is being missed.

Are people meeting these requirements another way?

I would greatly appreciate some clarity on this.

@gaearon
Copy link
Contributor

gaearon commented Mar 7, 2018

We're just using Uglify which preserves JSDoc-style comments that contain @preserve or @license in them. You can submit PRs to the libraries you're using to keep those in the compiled bundle if you'd like. I'm not sure if legally your distributed bundle counts as redistribution of the source code, or as compiled code, and I can't give you legal advice on this.

@gaearon gaearon closed this as completed Mar 7, 2018
@heymartinadams
Copy link

How do we tell create-react-app to preserve @preserve or @license? When I use react-scripts build, even though I have a @license in my index.js file, it still doesn’t include that license in the minified version.

@Timer
Copy link
Contributor

Timer commented Jun 11, 2018

Sounds like a bug then, @heymartinadams -- can you please file a new issue for this?

@heymartinadams
Copy link

Done. Thanks, @Timer!

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants