-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable reduce_vars in uglify-es due to bug in code generation #4692
Comments
Just created a pull request for it |
Another option to consider is to switch to https://github.com/fabiosantoscode/terser |
We've switched to terser. Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is this a bug report?
yes
Did you try recovering your dependencies?
yarn 1.7.0
Which terms did you search for in User Guide?
N/A
Environment
Environment:
OS: Windows 10
Node: 10.5.0
Yarn: 1.7.0
npm: 6.1.0
Watchman: Not Found
Xcode: N/A
Android Studio: Not Found
Description
Basically, in uglify-es, the reduce_vars (set to true by default) sometimes generates bad code as seen in mishoo/UglifyJS#3122
Although it seems to be fixed (to be released in an hypothetical uglify-es 3.3.10), today I found out that actually uglify-es is no longer mantained (see mishoo/UglifyJS#3156), so my recommendation in the time being is to add reduce_vars: false in the compress section of the UglifyJSPlugin for the time being so nobody else finds this problem.
The text was updated successfully, but these errors were encountered: