Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime chunk inlining and asset manifest #5172

Closed
gaearon opened this issue Sep 29, 2018 · 0 comments
Closed

Runtime chunk inlining and asset manifest #5172

gaearon opened this issue Sep 29, 2018 · 0 comments
Milestone

Comments

@gaearon
Copy link
Contributor

gaearon commented Sep 29, 2018

Took me a bit to figure out what this is about, but I guess it's saying that they have a script which goes over each file in asset manifest (e.g. to add a <script> for it to a custom HTML page template), but runtime chunk is not there.

I wonder how we could handle it. I guess folks who use asset manifest (e.g. Django integrations and similar) won't read the runtime chunk from our HTML. So it'll be broken anyway.

Should we both emit runtime chunks and inline it? Normally it gets unused but folks who read the manifest get a separate script.

@gaearon gaearon changed the title Non-existent files (e.g. runtime chunk) shouldn't appear in asset manifest Runtime chunk inlining and asset manifest Sep 29, 2018
@Timer Timer added this to the 2.0.0 milestone Sep 29, 2018
@lock lock bot locked and limited conversation to collaborators Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants