Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing usage of webpack rule.loader in react-scripts #5736

Closed
dbFlower opened this issue Nov 7, 2018 · 1 comment
Closed

Confusing usage of webpack rule.loader in react-scripts #5736

dbFlower opened this issue Nov 7, 2018 · 1 comment

Comments

@dbFlower
Copy link

dbFlower commented Nov 7, 2018

In webpack.config.prod.js L391 L405 L420 L437, loaderis used instead of use. See: webpack.config.prod.js .

In file webpack.config.dev.js L318 L326 L340 L346 , it's correct usage use. See: webpack.config.dev.js

Webpack4 documentation here:

Rule.loader is a shortcut to Rule.use: [ { loader } ]. See Rule.use and UseEntry.loader for details.
@Timer
Copy link
Contributor

Timer commented Nov 7, 2018

This was fixed as part of #5722

@Timer Timer closed this as completed Nov 7, 2018
@lock lock bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants