From 0cbe64a5ea90373e90471f1153afbdda5271b3cc Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Mon, 1 Oct 2018 12:44:31 -0400 Subject: [PATCH 1/2] Disable react/no-deprecated rule --- packages/eslint-config-react-app/index.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index f359dacdb19..b8a0aa0b16c 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -199,7 +199,10 @@ module.exports = { 'react/jsx-uses-react': 'warn', 'react/jsx-uses-vars': 'warn', 'react/no-danger-with-children': 'warn', - 'react/no-deprecated': 'warn', + // Disabled because of poor quality warnings + // See https://github.com/facebook/create-react-app/issues/5204 for + // blockers until its re-enabled + // 'react/no-deprecated': 'warn', 'react/no-direct-mutation-state': 'warn', 'react/no-is-mounted': 'warn', 'react/react-in-jsx-scope': 'error', From 4e2fdf13237ef1599cf5bf6c8051dbdb4aaae80d Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Mon, 1 Oct 2018 12:47:38 -0400 Subject: [PATCH 2/2] Changed wording --- packages/eslint-config-react-app/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index b8a0aa0b16c..92b65234a81 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -199,7 +199,7 @@ module.exports = { 'react/jsx-uses-react': 'warn', 'react/jsx-uses-vars': 'warn', 'react/no-danger-with-children': 'warn', - // Disabled because of poor quality warnings + // Disabled because of undesirable warnings // See https://github.com/facebook/create-react-app/issues/5204 for // blockers until its re-enabled // 'react/no-deprecated': 'warn',