Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct a comment mistype in webpack production config #855

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Correct a comment mistype in webpack production config #855

merged 1 commit into from
Oct 6, 2016

Conversation

MunGell
Copy link
Contributor

@MunGell MunGell commented Oct 5, 2016

my 2¢

@facebook-github-bot
Copy link

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email [email protected] with your details so we can update your status.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon merged commit 5c3ab84 into facebook:master Oct 6, 2016
@gaearon
Copy link
Contributor

gaearon commented Oct 6, 2016

Thanks!

kitze added a commit to kitze/custom-react-scripts that referenced this pull request Oct 6, 2016
@kitze
Merge branch 'master' of https://github.com/facebookincubator/create-…
002acf5 
…react-app

# By Dan Abramov (2) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app:
  Correct a comment mistype in webpack production config (facebook#855)
  load setupTests file at setupTestFramework stage (facebook#846)
  Spell check (facebook#845)
  Tweak readme
  Update instructions on publishing to GitHub pages (facebook#841)
  Make webpackHotDevClient support webpack 2 too (facebook#840)
  Tweak eject output
  Promote "React must be in scope" to be an error (facebook#822)
  Fix script name to open chrome (facebook#831)
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@MunGell @feiqitian
Correct a comment mistype in webpack production config (facebook#855)
b6673c3
jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
@MunGell @jarlef
Correct a comment mistype in webpack production config (facebook#855)
14dcf3d
maltestenzel pushed a commit to maltestenzel/custom-react-scripts that referenced this pull request Mar 7, 2018
@kitze
Merge branch 'master' of https://github.com/facebookincubator/create-…
3683bc8 
…react-app

# By Dan Abramov (2) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app:
  Correct a comment mistype in webpack production config (facebook#855)
  load setupTests file at setupTestFramework stage (facebook#846)
  Spell check (facebook#845)
  Tweak readme
  Update instructions on publishing to GitHub pages (facebook#841)
  Make webpackHotDevClient support webpack 2 too (facebook#840)
  Tweak eject output
  Promote "React must be in scope" to be an error (facebook#822)
  Fix script name to open chrome (facebook#831)
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MunGell @facebook-github-bot @gaearon