-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocSearch meta missing from the new released version #1792
Comments
HI @yangshun - did we decide to remove these meta tags purposely or just not implemented yet? |
I think it's more of the latter. We will need them back eventually. |
@yangshun would it help if I put together a pull request? I'd really like to have these merged so I can add search on my site 😄 |
@nebrelbug Sure but I don't exactly know what the correct fix should be (because I'm not familiar with Algolia). I initially thought this wasn't necessary because v2 doesn't have versioning yet, so there cannot be multiple versions of Algolia for a site. cc @endiliey |
We need a page of version <meta name="docsearch:language" content="lang" />
<meta name="docsearch:version" content="x" /> This should be implemented at the same time as versioning then :) |
Will leave this open for now to serve as reminder |
@endiliey how does v2.docusaurus.io currently implement this? |
there's no versioning yet so ofc there's no meta tag for that yet |
its done like this however https://v2.docusaurus.io/docs/docusaurus-core#head- |
🐛 Bug Report
I am part of the team from algolia/Docsearch which features search for Docusaurus. We rely on meta tags to pick up the right version from the pages generated by Docusaurus. The v2 does not include these meta tags anymore. The Algolia search experience will be broken due to duplicates for every websites we crawl
Have you read the Contributing Guidelines on issues?
yes
To Reproduce
(Write your steps here:)
Expected behavior
Docusaurus should include these meta tags
Same as 0eb6612
My guess is that this issue is due to the latest release of Docusaurus.
Happy to provide more details if needed.
cc @endiliey @JoelMarcey
The text was updated successfully, but these errors were encountered: