Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme gallery #3522

Open
slorber opened this issue Oct 2, 2020 · 4 comments
Open

Theme gallery #3522

slorber opened this issue Oct 2, 2020 · 4 comments
Labels
proposal This issue is a proposal, usually non-trivial change

Comments

@slorber
Copy link
Collaborator

slorber commented Oct 2, 2020

Theme gallery

We'd like to have multiple Docusaurus themes.

For now:

  • only the classic theme is usable, which does not give many options to users.
  • the bootstrap theme is a WIP but not really usable yet.
  • the community would also appreciate a Tailwind theme: New Tailwind theme #2961

We agreed that those themes should all rather implement the same UX and work with docs, blog, pages...
This way, we can:

  • Share some UI-related code across the 3 themes in a @docusaurus/utils-client package (edit: this is now @docusaurus/theme-common)
  • Share the same integration test suite
  • Share the same theme options, and validation/normalization
  • Only implement styled components per theme

Related issues to read, as we already had theme-gallery related discussions with @fanny here:

The integration test suite will be handled in a separate issue #3523


IMPORTANT: Algolia crawlers use DOM selectors to understand the hierarchy of the pages. We'll have to also make sure the default Algolia Docusaurus config works fine for all themes, so we should find a way to make the selectors "stable" across themes, in the same way they should be stable for tests. We'll probably add explicit "lvl0-lvl6" markers in each theme so that we don't break these selectors in the future.

See our current config: https://github.com/algolia/docsearch-configs/tree/master/configs/docusaurus-2.json

@slorber slorber added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. status: needs triage This issue has not been triaged by maintainers mlh Major League Hacking Fellowship and removed status: needs triage This issue has not been triaged by maintainers labels Oct 2, 2020
@vthirupathi
Copy link

Hi, is this still a desired feature? I'm considering working on it

@slorber
Copy link
Collaborator Author

slorber commented Nov 12, 2020

Hi @vthirupathi , this is still a desired feature, but we need to factorize some code to make this happen first, and then we'll likely delegate it to MLH interns.
We are not yet looking for external contributors for this issue.

@slorber slorber added the status: claimed Issue has been claimed by a contributor who plans to work on it. label Jan 21, 2021
@maurerbot
Copy link

Any ETA on the tailwind preset?

@slorber
Copy link
Collaborator Author

slorber commented Mar 8, 2021

no progress but we now have a "configurePostCss" hook and users are already using Tailwind with Docusaurus here: #2961

@Josh-Cena Josh-Cena added proposal This issue is a proposal, usually non-trivial change and removed feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. labels Oct 30, 2021
@Josh-Cena Josh-Cena removed status: claimed Issue has been claimed by a contributor who plans to work on it. mlh Major League Hacking Fellowship labels Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal This issue is a proposal, usually non-trivial change
Projects
None yet
Development

No branches or pull requests

4 participants