Fixing major Android editing issues #2035

fabiomcosta · 2019-03-14T22:29:47Z

This PR is a new attempt to address #1895

On #2031 I was trying to make compositions work using the data provided by that event, and even though that works well for most operational system, that doesn't work well for Android, where you can make composition updates in multiple places on the same composition transaction.

This PR is an improvement over that PR, in that it uses a DOM mutation observer during the compositionStart -> compositionEnd interval to detect the changes the user made, and then re-apply those to the ContentState on compositionEnd.

This approach is the one used by Prosemirror (see https://github.com/ProseMirror/prosemirror-view/blob/master/src/domobserver.js), which is the only Rich Text Editor I've tried that works well on Android.
Like previously mentioned, it allows multiple mutations on multiple places in the same composition transaction, which was impossible with the previous approach, and would cause DOM<->state inconsistencies in multiple use cases.

The intent of this PR is not to fix every single Android bug, but to have a consistent editing experience on Android without introducing bugs (ideally).

TODO, known issues:

Removing empty line breaks with doesn’t remove blocks.
Mutations on the same block (different leaf nodes) are not being properly applied.
Selection is not properly updated during composition events
Keep inlineStyleOverride working with a consistent behavior

TODO, others:

Test on Android Pie v9 API 28
Test on Android Oreo v8.1 API 27
Test on Android Oreo v8.0 API 26
Test on iPhone 12.1 (with Japanese Kana keyboard)
Test composition events on Chrome Desktop v73
Test composition on IE11 (I didn't know how to test composition events though)
Unit tests

Help test this PR

There are 3 ways to try out this PR.

Codesandbox: https://3ymzzlj9n5.codesandbox.io/ (uses draft-js-android-fix-beta.3)

Use the published draft-js-android-fix package: yarn install draft-js-android-fix

Note that this package might not be up-to-date, it's hard for me to guarantee I'll always remember to update the package, but I'll do my best.

The other way is guaranteed to be up-to-date, but has a longer setup:

run git clone https://github.com/facebook/draft-js.git
run git remote add fabiomcosta https://github.com/fabiomcosta/draft-js.git
run git fetch fabiomcosta
run git checkout -b attempt_android_fix_with_dom_diff fabiomcosta/attempt_android_fix_with_dom_diff
run yarn install (or use npm)
run open examples/draft-0-10-0/rich/rich.html, or any other example you'd like to test

Test Plan

On Android (Pie v9 API 28, Oreo v8.1 API 27, Oreo v8.0 API 26)

Type "d[space]"
Renders the letter "d" followed by a space.

Type "da[space]"
Renders the expected highlighted autocomplete option, "day" in this case.

Type "day[space][backspace][backspace][backspace][backspace]"
Properly removes the text without re-adding the previous text.

Type "d[space][enter][backspace][enter]"
Should render "d[space][enter]".

Known issues, that might not be fixed on this PR

Pressing ENTER during a composition doesn’t commit it. Ex: type "hel[enter]", and notice that nothing happens when you click enter, but the expected behavior is to commit that composition and add a line break.
Removing the last work from a block that has been auto-completed, will incorrectly remove it from the content state. Ex: type "aa" it should render something like "and and ". Now press backspace. At this point the content state is incorrectly set as "and ", but it should be "and and".
[minor] Arrow keys won't work during composition

Acknowledgments

Based on ideas from:
#1672
#1774
ianstormtaylor/slate#2565
http://prosemirror.net/

Useful links

Latest draft-js 0.10.5 sandbox (useful to compare with previous behavior): https://ko4zmx633v.codesandbox.io/
Plain contenteditable sandbox: https://q77yqk1nww.codesandbox.io/

…tempt_android_fix

…will never work with the data that comes from the event and will be working on a new approach next

fabiomcosta · 2019-03-14T22:30:15Z

There is still some cleanup to be done on this PR before anything.

fabiomcosta · 2019-03-15T14:21:17Z

src/component/handlers/edit/editOnSelect.js

  const documentSelection = getDraftEditorSelection(
    editorState,
-    editorNode.firstChild,
+    getContentEditableContainer(editor),


Just a refactor to use the newly created getContentEditableContainer

fabiomcosta · 2019-03-16T15:00:31Z

package.json

  "description": "A React framework for building text editors.",
-  "version": "0.10.5",
+  "version": "0.10.6-beta.0",


This will be reverted before merging

fabiomcosta · 2019-03-16T15:04:19Z

src/component/handlers/composition/DraftEditorCompositionHandler.js

+
+    // TODO, check if Facebook still needs this flag or if it could be removed.
+    // Since there can be multiple mutations providing a `composedChars` doesn't
+    // apply well on this new model.


@claudiopro would you know if we can remove this code or do we need to keep it somehow working?
If we keep it working it will be buggy, because we are now applying multiple mutations (which leads to multiple composedChars) on compositionEnd, which is not compatible with the arguments that we provide to handleBeforeInput here.

If draft_handlebeforeinput_composed_text is still being used at FB, I'd suggest to provide the composedChars from the first mutation, completely ignoring the other mutations, which should be fine for the common case. My main suggestion is still to stop depending on this code/gkflag.

fabiomcosta · 2019-03-16T15:08:37Z

src/component/handlers/edit/editOnInput.js

+        editor.update(newEditorState);
+        return;
+      }
+    }


This change is necessary because keyDown on draft-js edit mode on Android doesn't come with the correct keyCode, so, for example, when users press backspace we are not actually executing keyCommandPlainBackspace, which leads to an incorrect content state.

The input event comes with this inputType which lets us execute the correct action.
I still need to make sure older versions of Android also support this property (will do soon).

…tring for characterData mutation events

…e, including contentState and selectionState

claudiopro

Please address these linter issues, otherwise looking good 👍

claudiopro · 2019-05-07T11:23:09Z

src/component/handlers/composition/__tests__/DraftEditorCompostionHandler-test.js

+test('Can handle a single mutation', () => {
+  withGlobalGetSelectionAs({}, () => {
+    editor._latestEditorState = getEditorState({blockkey0: ''});
+    const mutations = Map({'blockkey0-0-0': '私'});


Please replace with the unicode literal escape sequence '\u79c1'

claudiopro · 2019-05-07T11:23:24Z

src/component/handlers/composition/__tests__/DraftEditorCompostionHandler-test.js

+    compositionHandler.onCompositionEnd(editor);
+    jest.runAllTimers();
+
+    expect(editorTextContent()).toBe('私');


claudiopro · 2019-05-07T11:24:35Z

src/component/handlers/composition/DOMObserver.js

+const USE_CHAR_DATA = UserAgent.isBrowser('IE <= 11');
+
+class DOMObserver {
+  observer: MutationObserver;


Please initialize this property or make it nullable changing the type to ?MutationObserver.

oh, good call.

claudiopro · 2019-05-07T11:26:21Z

src/component/handlers/composition/DOMObserver.js

+  observer: MutationObserver;
+  container: HTMLElement;
+  mutations: Map<string, string>;
+  onCharData: ({target: EventTarget, type: string}) => void;


This should also be initialized, or make it nullable.

claudiopro · 2019-05-07T11:27:29Z

src/component/handlers/edit/editOnInput.js

+     * https://w3c.github.io/input-events/#dom-inputevent-inputtype */
+    const {inputType} = e.nativeEvent;
+    if (inputType) {
+      let newEditorState = onInputType(inputType, editorState);


This is never reassigned, please declare it as const.

…tempt_android_fix_with_dom_diff

facebook-github-bot

@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

claudiopro · 2019-05-09T18:08:27Z

Thank you so much for contributing this improvement @fabiomcosta! This is now merged in master 🎉

facebook-github-bot · 2019-05-09T18:18:28Z

@claudiopro merged this pull request in 634bd29.

martin-badin · 2019-05-31T11:24:29Z

Hello, please create a new release with the tag #next for testing.

sunild · 2019-06-25T22:26:45Z

I'd love to see a new release w/this fix too! We're using some draft-js plugins and I haven't figured out how to make them work when installing from git (they can't find draft-js).

See facebookarchive#2035

Summary: This PR is a new attempt to address facebookarchive#1895 On facebookarchive#2031 I was trying to make compositions work using the data provided by that event, and even though that works well for most operational system, that doesn't work well for Android, where you can make composition updates in multiple places on the same composition transaction. This PR is an improvement over that PR, in that it uses a DOM mutation observer during the `compositionStart` -> `compositionEnd` interval to detect the changes the user made, and then re-apply those to the ContentState on `compositionEnd`. This approach is the one used by [Prosemirror](http://prosemirror.net/) (see https://github.com/ProseMirror/prosemirror-view/blob/master/src/domobserver.js), which is the only Rich Text Editor I've tried that works well on Android. Like previously mentioned, it allows multiple mutations on multiple places in the same composition transaction, which was impossible with the previous approach, and would cause DOM<->state inconsistencies in multiple use cases. The intent of this PR is not to fix every single Android bug, but to have a consistent editing experience on Android without introducing bugs (ideally). **TODO, known issues:** - [x] Removing empty line breaks with <backspace> doesn’t remove blocks. - [x] Mutations on the same block (different leaf nodes) are not being properly applied. - [x] Selection is not properly updated during composition events - [ ] Keep `inlineStyleOverride` working with a consistent behavior **TODO, others:** - [x] Test on Android Pie v9 API 28 - [x] Test on Android Oreo v8.1 API 27 - [x] Test on Android Oreo v8.0 API 26 - [x] Test on iPhone 12.1 (with Japanese Kana keyboard) - [x] Test composition events on Chrome Desktop v73 - [x] Test composition on IE11 (I didn't know how to test composition events though) - [x] Unit tests There are 3 ways to try out this PR. Codesandbox: https://3ymzzlj9n5.codesandbox.io/ (uses `draft-js-android-fix-beta.3`) Use the published [draft-js-android-fix](https://www.npmjs.com/package/draft-js-android-fix) package: `yarn install draft-js-android-fix` Note that this package might not be up-to-date, it's hard for me to guarantee I'll always remember to update the package, but I'll do my best. The other way is guaranteed to be up-to-date, but has a longer setup: * run `git clone https://github.com/facebook/draft-js.git` * run `git remote add fabiomcosta https://github.com/fabiomcosta/draft-js.git` * run `git fetch fabiomcosta` * run `git checkout -b attempt_android_fix_with_dom_diff fabiomcosta/attempt_android_fix_with_dom_diff` * run `yarn install` (or use `npm`) * run `open examples/draft-0-10-0/rich/rich.html`, or any other example you'd like to test Pull Request resolved: facebookarchive#2035 Reviewed By: kedromelon Differential Revision: D14568528 Pulled By: claudiopro fbshipit-source-id: 16861de52eca41cd98f884b0aecf034213fc1bd0

michelson · 2020-03-01T06:53:48Z

Hi @fabiomcosta , this was released as a npm version? I've upgraded to 0.11.4 but the space error on android is still present.

Summary: This PR is a new attempt to address facebookarchive#1895 On facebookarchive#2031 I was trying to make compositions work using the data provided by that event, and even though that works well for most operational system, that doesn't work well for Android, where you can make composition updates in multiple places on the same composition transaction. This PR is an improvement over that PR, in that it uses a DOM mutation observer during the `compositionStart` -> `compositionEnd` interval to detect the changes the user made, and then re-apply those to the ContentState on `compositionEnd`. This approach is the one used by [Prosemirror](http://prosemirror.net/) (see https://github.com/ProseMirror/prosemirror-view/blob/master/src/domobserver.js), which is the only Rich Text Editor I've tried that works well on Android. Like previously mentioned, it allows multiple mutations on multiple places in the same composition transaction, which was impossible with the previous approach, and would cause DOM<->state inconsistencies in multiple use cases. The intent of this PR is not to fix every single Android bug, but to have a consistent editing experience on Android without introducing bugs (ideally). **TODO, known issues:** - [x] Removing empty line breaks with <backspace> doesn’t remove blocks. - [x] Mutations on the same block (different leaf nodes) are not being properly applied. - [x] Selection is not properly updated during composition events - [ ] Keep `inlineStyleOverride` working with a consistent behavior **TODO, others:** - [x] Test on Android Pie v9 API 28 - [x] Test on Android Oreo v8.1 API 27 - [x] Test on Android Oreo v8.0 API 26 - [x] Test on iPhone 12.1 (with Japanese Kana keyboard) - [x] Test composition events on Chrome Desktop v73 - [x] Test composition on IE11 (I didn't know how to test composition events though) - [x] Unit tests There are 3 ways to try out this PR. Codesandbox: https://3ymzzlj9n5.codesandbox.io/ (uses `draft-js-android-fix-beta.3`) Use the published [draft-js-android-fix](https://www.npmjs.com/package/draft-js-android-fix) package: `yarn install draft-js-android-fix` Note that this package might not be up-to-date, it's hard for me to guarantee I'll always remember to update the package, but I'll do my best. The other way is guaranteed to be up-to-date, but has a longer setup: * run `git clone https://github.com/facebook/draft-js.git` * run `git remote add fabiomcosta https://github.com/fabiomcosta/draft-js.git` * run `git fetch fabiomcosta` * run `git checkout -b attempt_android_fix_with_dom_diff fabiomcosta/attempt_android_fix_with_dom_diff` * run `yarn install` (or use `npm`) * run `open examples/draft-0-10-0/rich/rich.html`, or any other example you'd like to test Pull Request resolved: facebookarchive#2035 Reviewed By: kedromelon Differential Revision: D14568528 Pulled By: claudiopro fbshipit-source-id: 16861de52eca41cd98f884b0aecf034213fc1bd0

NNSTH · 2020-08-27T08:54:39Z

I'm using draft-js version: 0.11.6 and still having lot of Android issues, what am I missing?

lousander · 2021-01-26T20:10:03Z

Hey! I've been experiencing some weirds issues with my custom components. It started on version v11.0.0 and seems to be related to this PR. The issue happens when typing brazilian portuguese, we have some letters that use accents e.g., é, ê, ã, etc, so in draft-js they are compositions. Typing any of these triggers an unmount on all our custom components. It can be really troublesome if we have a custom component that does a request or some async code, as it keeps redoing it every time we type any of those letters.

From what I can tell this issue seems to be directly tied to the alterations made here to the DraftEditorCompositionHandler.js file. Apparently after any kind of composition, it calls the method restoreEditorDOM, which is described as "a complete re-render of the DraftEditorContents based on the current EditorState". Before this PR, this method was only called when certain conditions were met (by using the mustReset flag), now it seems to happen everytime a composition is completed. I'm trying to wok out some way to correct this behavior but I'm having some difficulties. @fabiomcosta Do you think you could shed some light on a way to tackle this?

yongningfu · 2021-02-01T08:21:27Z

Hey! I've been experiencing some weirds issues with my custom components. It started on version v11.0.0 and seems to be related to this PR. The issue happens when typing brazilian portuguese, we have some letters that use accents e.g., é, ê, ã, etc, so in draft-js they are compositions. Typing any of these triggers an unmount on all our custom components. It can be really troublesome if we have a custom component that does a request or some async code, as it keeps redoing it every time we type any of those letters.

From what I can tell this issue seems to be directly tied to the alterations made here to the DraftEditorCompositionHandler.js file. Apparently after any kind of composition, it calls the method restoreEditorDOM, which is described as "a complete re-render of the DraftEditorContents based on the current EditorState". Before this PR, this method was only called when certain conditions were met (by using the mustReset flag), now it seems to happen everytime a composition is completed. I'm trying to wok out some way to correct this behavior but I'm having some difficulties. @fabiomcosta Do you think you could shed some light on a way to tackle this?

@claudiopro @fabiomcosta When typing Chinese, the problem reappears

offcall · 2021-10-08T09:50:08Z

I am experiencing the same problem, if composition is entered next to entity, then mutation contains text from entity and breaks it

Summary: This PR is a new attempt to address facebookarchive/draft-js#1895 On facebookarchive/draft-js#2031 I was trying to make compositions work using the data provided by that event, and even though that works well for most operational system, that doesn't work well for Android, where you can make composition updates in multiple places on the same composition transaction. This PR is an improvement over that PR, in that it uses a DOM mutation observer during the `compositionStart` -> `compositionEnd` interval to detect the changes the user made, and then re-apply those to the ContentState on `compositionEnd`. This approach is the one used by [Prosemirror](http://prosemirror.net/) (see https://github.com/ProseMirror/prosemirror-view/blob/master/src/domobserver.js), which is the only Rich Text Editor I've tried that works well on Android. Like previously mentioned, it allows multiple mutations on multiple places in the same composition transaction, which was impossible with the previous approach, and would cause DOM<->state inconsistencies in multiple use cases. The intent of this PR is not to fix every single Android bug, but to have a consistent editing experience on Android without introducing bugs (ideally). **TODO, known issues:** - [x] Removing empty line breaks with <backspace> doesn’t remove blocks. - [x] Mutations on the same block (different leaf nodes) are not being properly applied. - [x] Selection is not properly updated during composition events - [ ] Keep `inlineStyleOverride` working with a consistent behavior **TODO, others:** - [x] Test on Android Pie v9 API 28 - [x] Test on Android Oreo v8.1 API 27 - [x] Test on Android Oreo v8.0 API 26 - [x] Test on iPhone 12.1 (with Japanese Kana keyboard) - [x] Test composition events on Chrome Desktop v73 - [x] Test composition on IE11 (I didn't know how to test composition events though) - [x] Unit tests There are 3 ways to try out this PR. Codesandbox: https://3ymzzlj9n5.codesandbox.io/ (uses `draft-js-android-fix-beta.3`) Use the published [draft-js-android-fix](https://www.npmjs.com/package/draft-js-android-fix) package: `yarn install draft-js-android-fix` Note that this package might not be up-to-date, it's hard for me to guarantee I'll always remember to update the package, but I'll do my best. The other way is guaranteed to be up-to-date, but has a longer setup: * run `git clone https://github.com/facebook/draft-js.git` * run `git remote add fabiomcosta https://github.com/fabiomcosta/draft-js.git` * run `git fetch fabiomcosta` * run `git checkout -b attempt_android_fix_with_dom_diff fabiomcosta/attempt_android_fix_with_dom_diff` * run `yarn install` (or use `npm`) * run `open examples/draft-0-10-0/rich/rich.html`, or any other example you'd like to test Pull Request resolved: facebookarchive/draft-js#2035 Reviewed By: kedromelon Differential Revision: D14568528 Pulled By: claudiopro fbshipit-source-id: 16861de52eca41cd98f884b0aecf034213fc1bd0

fabiomcosta added 11 commits March 2, 2019 19:28

Much saner experience, but still with known issues that Im taking notes.

83730c9

Merge branch 'master' of https://github.com/facebook/draft-js into at…

939f935

…tempt_android_fix

Improving code a bit

c831fcf

minor cleanup

1d55ab4

fixing flow issues

7322ff4

revert header changes

7e67808

keeping draft_handlebeforeinput_composed_text experiment

314e3db

Removing code added by accident

65120e8

Merge branch 'master' of https://github.com/facebook/draft-js into at…

8c3e6ab

…tempt_android_fix

fixing more issues realted to composition, but I finaly noticed this …

2f7ac3f

…will never work with the data that comes from the event and will be working on a new approach next

Detecting DOM changes using a mutation observer on composition events

1800a0e

facebook-github-bot added the CLA Signed label Mar 14, 2019

removing console.logs and removing unecessary compositionUpdate handler

49ddeb5

fabiomcosta commented Mar 15, 2019

View reviewed changes

improving comments around the new onInput changes

b10bcc7

fabiomcosta mentioned this pull request Mar 15, 2019

[WIP] Attempt on fixing known Android issues #2031

Closed

2 tasks

fabiomcosta added 2 commits March 16, 2019 11:20

fixing flow and lint errors and warnings

2be6cfb

v0.10.6-beta.0

2fbe986

fabiomcosta mentioned this pull request Mar 16, 2019

Fix Android input bugs #1672

Open

adding unit tests for getContentEditableContainer

fbfb983

fabiomcosta commented Mar 16, 2019

View reviewed changes

fabiomcosta added 6 commits March 16, 2019 12:09

const editorState

4b4c028

better info on keeping the selection state.

9ff84ce

Fixes an issue that happens when the target textContent is an empty s…

586ce9e

…tring for characterData mutation events

v0.10.6-beta.1

a560b8b

Making sure multiple mutations are properly applied to the editorStat…

9e0ac50

…e, including contentState and selectionState

v0.10.6-beta.2

d3a3f98

claudiopro suggested changes May 7, 2019

View reviewed changes

fabiomcosta added 2 commits May 7, 2019 13:59

Merge branch 'master' of https://github.com/facebook/draft-js into at…

5c70301

…tempt_android_fix_with_dom_diff

updates based on CR

2927e4f

facebook-github-bot reviewed May 9, 2019

View reviewed changes

facebook-github-bot closed this in 634bd29 May 9, 2019

facebook-github-bot added the Merged label May 9, 2019

claudiopro mentioned this pull request Jun 19, 2019

Critical error when using React from version 16.0.0 on Android #2086

Closed

fraziermork added a commit to textioHQ/draft-js that referenced this pull request Jul 16, 2019

Add fix for android keyboards

acb05db

See facebookarchive#2035

ssunday mentioned this pull request Jul 29, 2019

[Shallow] Implement callEffects option to call effects from shallow renderer (#15275) facebook/react#16168

Closed

jdecked mentioned this pull request Sep 20, 2019

Inserting decorated emojis while using an IME crashes editor #2187

Closed

ScottLindley mentioned this pull request Sep 30, 2019

Mobile View Editing Bug sstur/react-rte#257

Open

erikt9 mentioned this pull request Oct 10, 2019

Space bar is clearing text. Samsun Galaxy 9 - Chome - sstur/react-rte#344

Open

snyk-bot mentioned this pull request Feb 23, 2020

[Snyk] Upgrade draft-js from 0.10.5 to 0.11.4 saurabharch/guesstimate-app#5

Open

michelson mentioned this pull request Mar 2, 2020

integrate a fallback editor for mobile chaskiq/chaskiq#126

Merged

lousander mentioned this pull request Jan 21, 2021

Custom block will unmount when you type Chinese, but not when you type English #2788

Open

offcall mentioned this pull request Oct 8, 2021

Fix composition mode #3073

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing major Android editing issues #2035

Fixing major Android editing issues #2035

fabiomcosta commented Mar 14, 2019 •

edited

Loading

fabiomcosta commented Mar 14, 2019

fabiomcosta Mar 15, 2019

fabiomcosta Mar 16, 2019

fabiomcosta Mar 16, 2019 •

edited

Loading

fabiomcosta Mar 16, 2019

claudiopro left a comment

claudiopro May 7, 2019

claudiopro May 7, 2019

claudiopro May 7, 2019

fabiomcosta May 7, 2019

claudiopro May 7, 2019

claudiopro May 7, 2019

facebook-github-bot left a comment

claudiopro commented May 9, 2019

facebook-github-bot commented May 9, 2019

martin-badin commented May 31, 2019

sunild commented Jun 25, 2019 •

edited

Loading

michelson commented Mar 1, 2020

NNSTH commented Aug 27, 2020

lousander commented Jan 26, 2021

yongningfu commented Feb 1, 2021

offcall commented Oct 8, 2021 •

edited

Loading

Fixing major Android editing issues #2035

Fixing major Android editing issues #2035

Conversation

fabiomcosta commented Mar 14, 2019 • edited Loading

Help test this PR

Test Plan

On Android (Pie v9 API 28, Oreo v8.1 API 27, Oreo v8.0 API 26)

Known issues, that might not be fixed on this PR

Acknowledgments

Useful links

fabiomcosta commented Mar 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabiomcosta Mar 16, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

claudiopro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

claudiopro commented May 9, 2019

facebook-github-bot commented May 9, 2019

martin-badin commented May 31, 2019

sunild commented Jun 25, 2019 • edited Loading

michelson commented Mar 1, 2020

NNSTH commented Aug 27, 2020

lousander commented Jan 26, 2021

yongningfu commented Feb 1, 2021

offcall commented Oct 8, 2021 • edited Loading

fabiomcosta commented Mar 14, 2019 •

edited

Loading

fabiomcosta Mar 16, 2019 •

edited

Loading

sunild commented Jun 25, 2019 •

edited

Loading

offcall commented Oct 8, 2021 •

edited

Loading