-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): jest should not count PerformanceObserver as an open handle #11123
fix(): jest should not count PerformanceObserver as an open handle #11123
Conversation
Hi @micaelmbagira! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thanks! Could you add a test as well? |
Codecov Report
@@ Coverage Diff @@
## master #11123 +/- ##
==========================================
+ Coverage 64.06% 64.18% +0.12%
==========================================
Files 307 307
Lines 13370 13370
Branches 3262 3262
==========================================
+ Hits 8565 8582 +17
+ Misses 4107 4083 -24
- Partials 698 705 +7
Continue to review full report at Codecov.
|
@SimenB Done, let me know if something else is missing. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Some actions are failing but seems to be unrelated to the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just left a couple of nits
Thanks @micaelmbagira! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #11051
Summary
Test plan