Add server.forwardClientLogs config option #1192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52768531 |
huntie
added a commit
to huntie/metro
that referenced
this pull request
Jan 17, 2024
Summary: Add an option to disable reporting of forwarded client logs (via `WebsocketServiceInterface.onClientMessage`). In React Native, this enables user opt out from console logs in `metro.config.js`. Resolves facebook#484, react-native-community/cli#794. Changelog: **[Feature]** Add `server.forwardClientLogs` config option Differential Revision: D52768531
huntie
force-pushed
the
export-D52768531
branch
from
dd88bc3 to
8f6aa1f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52768531 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D52768531 |
Summary: Add an option to disable reporting of forwarded client logs (via `WebsocketServiceInterface.onClientMessage`). In React Native, this enables user opt out from console logs in `metro.config.js`. Resolves facebook#484, react-native-community/cli#794. Changelog: **[Feature]** Add `server.forwardClientLogs` config option Reviewed By: robhogan Differential Revision: D52768531
huntie
force-pushed
the
export-D52768531
branch
from
8f6aa1f to
8f2357b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52768531 |
|
This pull request has been merged in c892bf7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add an option to disable reporting of forwarded client logs (via
WebsocketServiceInterface.onClientMessage). In React Native, this enables user opt out from console logs inmetro.config.js.Resolves #484, react-native-community/cli#794.
Changelog: [Feature] Add
server.forwardClientLogsconfig optionDifferential Revision: D52768531