fix(metro-resolver): package exports restricted paths #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1239 +/- ##
=======================================
Coverage 83.47% 83.48%
=======================================
Files 207 207
Lines 10731 10734 +3
Branches 2673 2675 +2
=======================================
+ Hits 8958 8961 +3
Misses 1773 1773 ☔ View full report in Codecov by Sentry. |
huntie
approved these changes
Mar 22, 2024
|
@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jbroma I've updated the summary with a Landing this PR now, hopefully makes it into today's release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR deals with restricting internal paths through the most specific subpath pattern edge case from #1236
reduceConditionalExportto account for implicit default conditionChangelog: [Experimental] Fix implicit default condition to be
nullfor subpath patterns (edge case)Test plan