Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatlist example in the docs not rendering #13037

Closed
whoyawn opened this issue Mar 20, 2017 · 3 comments
Closed

Flatlist example in the docs not rendering #13037

whoyawn opened this issue Mar 20, 2017 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@whoyawn
Copy link

whoyawn commented Mar 20, 2017

Description

On the documentation for Flatlist, I tried running the example in the browser. I then got an error on the simulator saying "FlatListExample could not be found!"

Reproduction

Link to docs

I go onto the docs, and click "Run this example" near the bottom.

Solution

The documentation for that page needs to be updated with the latest repository.

Additional Information

  • React Native version: 0.43.0
  • Platform: Documentation, Google Chrome
  • Operating System: MacOS
  • Dev tools: None
@hramos
Copy link
Contributor

hramos commented Mar 21, 2017

I think this is actually affecting more than just FlatList. Other examples are not rendering. RNPlay is going away at the end of the month, so we'll need to either migrate the examples to run in Sketch, or remove the prompt entirely.

@hramos
Copy link
Contributor

hramos commented Mar 21, 2017

I took a further look at this. So there's two different types of runnable examples that display in a modal:

  1. One-off examples linked from the markdown docs (e.g. https://facebook.github.io/react-native/docs/direct-manipulation.html), which is something someone uploaded to RNPlay long ago - and in some cases, the example no longer exists. In the case of Direct Manipulation, the example was created before RNPlay switched to Expo, and has been disabled: https://rnplay.org/apps/JXkgmQ

  2. Then there's the examples in the API docs (such as StatusBar) where we use one of two UIExplorer apps uploaded to appetize.org around two years ago (iOS and Android), and pass along some params to load the correct example. This is why FlatList fails to load in this case, because the UIExplorer app being used here hasn't been updated in some time and does not contain FlatList.

For #1, we can migrate these examples to Sketch.

For #2, we can update the app on appetize to use a more up to date version of UIExplorer, but we would also need to make this more resilient as the issue will show up again when a new component is added to UIExplorer. Not to say, the examples are likely to get out of sync as the UIExplorer app gets updated in the repo.

@hramos
Copy link
Contributor

hramos commented Apr 24, 2017

#1 has been resolved on master, and #13644 takes care of #2.

@hramos hramos closed this as completed Apr 24, 2017
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants