You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.
Is this a bug report?
Yes
Environment
react-native -v
: 0.46Target Platform: Android
Development Operating System: macOS
Steps to Reproduce
Systrace module in RN depends on hooks like
nativeTraceBeginSection
to exists (see https://github.com/facebook/react-native/blob/master/Libraries/Performance/Systrace.js#L134). But they are added here which isn't run becuase it requiresfbsystrace.h
to exist.nativeTraceBeginSection
and/ornativeTraceBeginSection
WITH_JSC_EXTRA_TRACING
. Fails because it's missingfbsystrace.h
Expected Behavior
Would be really helpful to be able to see what JSC is doing within a systrace on android
The text was updated successfully, but these errors were encountered: