Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systrace is not enabled for JSC on Android #15022

Closed
MarcoPolo opened this issue Jul 14, 2017 · 2 comments
Closed

Systrace is not enabled for JSC on Android #15022

MarcoPolo opened this issue Jul 14, 2017 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@MarcoPolo
Copy link
Contributor

Is this a bug report?

Yes

Environment

  • react-native -v: 0.46

  • Target Platform: Android

  • Development Operating System: macOS

Steps to Reproduce

Systrace module in RN depends on hooks like nativeTraceBeginSection to exists (see https://github.com/facebook/react-native/blob/master/Libraries/Performance/Systrace.js#L134). But they are added here which isn't run becuase it requires fbsystrace.h to exist.

  1. Try to use Systrace module. Fails because it's missing nativeTraceBeginSection and/or nativeTraceBeginSection
  2. Try to add those by enabling WITH_JSC_EXTRA_TRACING. Fails because it's missing fbsystrace.h

Expected Behavior

Would be really helpful to be able to see what JSC is doing within a systrace on android

@jayshah123
Copy link
Contributor

I have filed a similar issue regarding missing systrace due to fbsystrace.h @ #14394

@hramos
Copy link
Contributor

hramos commented Sep 21, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Sep 21, 2017
@hramos hramos closed this as completed Sep 21, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Sep 21, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants