Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NavigatorIOS] Titlebar has margin in iOS 11 (not in iOS 9.3) #15681

Closed
yvbeek opened this issue Aug 28, 2017 · 4 comments
Closed

[NavigatorIOS] Titlebar has margin in iOS 11 (not in iOS 9.3) #15681

yvbeek opened this issue Aug 28, 2017 · 4 comments
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@yvbeek
Copy link

yvbeek commented Aug 28, 2017

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

  1. react-native -v: react-native-cli: 2.0.1, react-native: 0.47.2
  2. node -v: v8.4.0
  3. npm -v: 5.3.0
  4. yarn --version: 0.27.5
  • Target Platform: iOS
  • Development Operating System: macOS
  • Build tools: Xcode

Steps to Reproduce

The NavigatorIOS navigation bar doesn't seem to render properly under iOS 11.

Expected Behavior

The NavigatorIOS navigation bar should render in iOS 11 like it does in iOS 9.

bug-ios9

Actual Behavior

There is a margin under the titlebar that shouldn't be there.

bug-ios11

Reproducible Demo

This snack contains a simplified version of the structure in my app.
Unfortunately I can't seem to select an iOS version in Snack, so you don't see the margin issue.

https://snack.expo.io/H1TNLMMFW

@WATER1350
Copy link

WATER1350 commented Sep 2, 2017

This issue is caused by safeArea concept introduced by iOS 11 and set the property contentInsetAdjustmentBehavior of UIScrollView will fix it. Just like:
scrollView.contentInsetAdjustmentBehavior = UIScrollViewContentInsetAdjustmentNever.

@yvbeek
Copy link
Author

yvbeek commented Sep 4, 2017

Awesome, so this should be a relative simple fix in the source?

@stale
Copy link

stale bot commented Nov 3, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 3, 2017
@yvbeek
Copy link
Author

yvbeek commented Nov 3, 2017

I've decided to stop using NavigatorIOS. It often contains bugs and of course isn't a solution that we can use for Android. I'm now using React Navigation, that works great!

@yvbeek yvbeek closed this as completed Nov 3, 2017
@facebook facebook locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

2 participants