Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Start/Stop Sampling Profiler" not working on Android #18044

Closed
dannycochran opened this issue Feb 21, 2018 · 18 comments
Closed

"Start/Stop Sampling Profiler" not working on Android #18044

dannycochran opened this issue Feb 21, 2018 · 18 comments
Labels
Bug Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@dannycochran
Copy link
Contributor

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: macOS High Sierra 10.13.3
Node: 6.10.3
Yarn: 1.3.2
npm: 3.10.10
Watchman: Not Found
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: Not Found

Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.53.3 => 0.53.3

Target Platform: Android API 23, Nexus 5X

Steps to Reproduce

  1. create a new react-native app from scratch (or use the repo I provided below)
  2. react-native run-android
  3. open debugging menu
  4. tap "Start/Stop Sampling Profiler"
  5. get red screen and error

Expected Behavior

I would be able to start profiling memory usage in my react-native app

Actual Behavior

"TypeError: undefined is not a function (evaluating 'global.pokeSamplingProfiler()')"

screen shot 2018-02-21 at 9 55 19 am

Reproducible Demo

Either create a react-native repo from scratch, or use this repo here which is just that (no local modifications made after react-native init):

https://github.com/dannycochran/rn-profiler

@hramos hramos added the Android label Mar 8, 2018
@react-native-bot react-native-bot added the Ran Commands One of our bots successfully processed a command. label Mar 18, 2018
@react-native-bot react-native-bot added Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. labels Mar 18, 2018
@evanjmg
Copy link

evanjmg commented Mar 21, 2018

Same here for Nexus 4, 5.1.1 +1

@tuomohopia
Copy link

I seem to be hitting the same problem on both, Android Studio emulator as well as on my own Oneplus 5T.

RN 0.55

@aayushis12
Copy link

same with Android 8.0.0

@Lidanha
Copy link

Lidanha commented Jun 23, 2018

Hey guys,

I have the same issue, is there a workaround for finding performance issues?

Thanks,
Lidan

@337240552
Copy link

android 6.0 Rn 0.55.0

@JulianKingman
Copy link

I get the same global.pokeSamplingProfiler. I'm using ExpoKit 28.0.0, fwiw

@haggholm
Copy link

Ditto. Same as #15003?

@fzyzcjy
Copy link

fzyzcjy commented Aug 22, 2018

same +1, rn 0.55

@fzyzcjy
Copy link

fzyzcjy commented Aug 28, 2018

Any ideas? :/

@tuomohopia
Copy link

Still getting this at RN 0.57.2 - anyone got any closer to understanding the root of the problem?

@sesam
Copy link

sesam commented Oct 17, 2018

Getting this on both 0.55.4 and 0.57.1

@armaanahluwalia
Copy link

Same on android with RN 0.55.4

1 similar comment
@henrymoulton
Copy link
Contributor

Same on android with RN 0.55.4

@axe-fb
Copy link
Contributor

axe-fb commented Nov 27, 2018

I think we no longer use the sample profiler. I would recommend using Systrace.

Here is a post I wrote about profiling- http://blog.nparashuram.com/2018/11/react-native-performance-playbook-part-i.html

@stale
Copy link

stale bot commented Aug 2, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Aug 2, 2019
@axe-fb
Copy link
Contributor

axe-fb commented Aug 2, 2019

I am working on a fix for this.

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Aug 2, 2019
@stale
Copy link

stale bot commented Oct 31, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 31, 2019
@stale
Copy link

stale bot commented Nov 7, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Nov 7, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests