Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onKeyPress being called after dictation in iOS #22139

Closed
3 tasks done
elliscwc opened this issue Nov 5, 2018 · 1 comment
Closed
3 tasks done

onKeyPress being called after dictation in iOS #22139

elliscwc opened this issue Nov 5, 2018 · 1 comment
Labels
Bug Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.

Comments

@elliscwc
Copy link

elliscwc commented Nov 5, 2018

Environment

React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: x64 Intel(R) Core(TM) i5-7400 CPU @ 3.00GHz
Memory: 405.82 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.12.0 - /usr/local/bin/node
Yarn: 1.10.1 - /usr/local/bin/yarn
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
iOS SDK:
Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
IDEs:
Android Studio: 3.0 AI-171.4443003
Xcode: 10.0/10A255 - /usr/bin/xcodebuild
npmPackages:
react: 16.5.0 => 16.5.0
react-native: 0.57.4 => 0.57.4

Description

In iOS, when the text dictation ends, onKeyPress event is called for unknown reason.

  • The onKeyPress event return Backspace key which interfere with our text input logic.
  • The event with that key doesn't actually delete a letter.

Please consider removing it, thank you~!

Reproducible Demo

Somehow it must test on device instead of appetize for the demo to work.
https://snack.expo.io/@elliscwc/onkeypress-after-dictation

@cpojer
Copy link
Contributor

cpojer commented Apr 2, 2019

You are right, this seems like this is a real issue but unfortunately it's unlikely anyone will be able to spend time on this anytime soon. I'm going to close this issue but we are more than happy to receive a pull request with a fix for this!

@cpojer cpojer closed this as completed Apr 2, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Apr 2, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants