-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RCTWeakProxy displayDidRefresh:]: unrecognized selector sent to instance 0x28048f800 #27463
Comments
This comment has been minimized.
This comment has been minimized.
Same issue with me. |
This comment has been minimized.
This comment has been minimized.
same here. started seeing this since 0.61 in our user crashlogs 🤕 |
here's the full stacktrace
|
Last Exception Backtrace: |
i think this commit makes this issue 6d6b532 |
Summary: @public CADisplayLink strongly holds onto its target, so you have to use a weak proxy object to pass the target into the CADisplayLink. Previously we passed a weak-self point (i.e. weakSelf) but this did not have the intended effect, since the pointer to self would still be passed to CADisplayLink, and thus it would hold onto the RCTUIImageViewAnimated strongly. So is weakSelf doing anything other than using self? It is but it's very minor and not useful. In the case that the object got de-allocated between assigning self to weakSelf and creating the CADisplayLink, then we would pass a nil target. This is actually impossible though because we are running an instance method, so self is implicitly retained! So semantically it is something different but in practice it is the same as passing self through. Notes: * This system was added originally in #24822 * #25636 then "enabled" this system by deprecating existing approach Reviewed By: fkgozali Differential Revision: D16939869 fbshipit-source-id: 7a0e947896f23aa30ad074d1dcb4d4db7543e00a
Same issue here. Started seeing this since RN 0.61 in app crashlogs. |
Any update on this? |
I got the same in crashlytics. Any solution yet? |
any update on this? I got some crash becuase of this issue on store. do anyone have any solution? |
Sorry for the lack of update. We haven't found any traces in FB production crashes that matched this issue, so it's hard to know how to address this. Can someone create a minimal repro steps using a sample screen inside RNTester iOS? With smaller repro steps, it'll be easier to triage and find a solution. |
@fkgozali
and also here is my
'm getting at least 1k crash every day becuase of this issue |
@omid-zamani what makes you think those are related... ? 🤔 |
Right, that's the stack trace, but we still don't have a solid way to reproduce the issue, i.e. what kind of code in your app triggered this crash? #19078 is an old issue, I don't think it is related to RCTWeakProxy. |
@fkgozali |
Any chance you could put your FlatList usage sample code somewhere in RNTester JS as a repro case? If we can repro the crash with RNTester, I think that would be a big step towards debugging the problem. |
I am seeing this as well from my bugsnag, but could not get my head around where the issue stems from. NSException object:
What would this exactly mean? Something to do with Stack Trace:
react-native info:
One interest finding is that the devices having this issue are confined to iPhone 7 Plus(37.3%), iPhone 6S(32.0%), iPhone 7(21.3%), iPhone SE(6.7%) - old devices on iOS 13.3.1 or 13.4.1. Probably I should test with one of these devices first. Will get back if I have any more finding. |
We found this commit that seems to address the issue: e5a6655 Maybe we can close this now? |
Are any estimates on it? |
Yes, this should be fixed in master. Closing |
Hi @fkgozali, I'm using the v0.62, and I am still getting this issue. Is there any workaround to fix it until the v0.63 has been released? |
For a temp workaround, we applied a small patch inspired by #28070 through a postinstall script in
|
@DongDongDongDong I'm facing the same issue, Is there any solution yet? My react-native version is 0.62.2. |
Anyone knows is this issue fixed in react-native version is 0.63? |
same issue in Rn 0.63.3 |
Same issue on rn 0.62.2 Also, it seems like certain devices are affected according to my crashlytics report:
|
It looks like the fix will arrive in 0.64. |
small probability of the following error:
-[RCTWeakProxy displayDidRefresh:]: unrecognized selector sent to instance 0x28048f800
NSInvalidArgumentException
React Native version:0.61
The text was updated successfully, but these errors were encountered: