Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactNative 0.73 did not include the Hermes WeakMap memory leak fix #42620

Closed
edkimmel opened this issue Jan 23, 2024 · 4 comments
Closed

ReactNative 0.73 did not include the Hermes WeakMap memory leak fix #42620

edkimmel opened this issue Jan 23, 2024 · 4 comments
Labels
Newer Patch Available Resolution: Answered When the issue is resolved with a simple answer

Comments

@edkimmel
Copy link

Description

It looks like ReactNative 0.73 took a build of hermes from September 2023. The WeakMap memory leak was fixed in November. facebook/hermes@e7b2abe

Would it be possible to get a minor version / hotfix built of 0.73 to include that fix? Right now, our choices are to patch and host a custom hermes ourselves or to continue to call GC manually to work around the issue.

Steps to reproduce

facebook/hermes@e7b2abe

React Native Version

0.73.0

Affected Platforms

Runtime - Android, Runtime - iOS

Output of npx react-native info

N/A

Stacktrace or Logs

N/A

Reproducer

facebook/hermes@e7b2abe

Screenshots and Videos

No response

Copy link

⚠️ Newer Version of React Native is Available!
ℹ️ You are on a supported minor version, but it looks like there's a newer patch available - 0.73.2. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

Copy link

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

@github-actions github-actions bot added Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Jan 23, 2024
@edkimmel edkimmel changed the title ReactNative 0.73 did not include the WeakMap memory leak fix ReactNative 0.73 did not include the Hermes WeakMap memory leak fix Jan 23, 2024
@cortinico
Copy link
Contributor

Closing as you should ask for this pick here:
reactwg/react-native-releases#98

The change doesn't look that invasive so we should be able to pick it. However we'll need to get a confirmation from @neildhar @tmikov that it's safe to pick this change on for 0.73.

@cortinico cortinico added Resolution: Answered When the issue is resolved with a simple answer and removed Needs: Triage 🔍 Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Jan 23, 2024
@neildhar
Copy link
Contributor

Confirming that this is safe to pick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Newer Patch Available Resolution: Answered When the issue is resolved with a simple answer
Projects
None yet
Development

No branches or pull requests

3 participants