-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.18] Things we should cherry-pick to 0.18 #5201
Comments
Should also cherry pick 4f9086f , 7ecb693 And may be this, 5a3b272 (Flow gives lots of warnings due to this, and is almost unusable, though there are other warnings too, this will at least decrease them) Also in https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/ReactActivity.java , it now extends PR here - #5206 |
180fc06 Fixes iOS 7 |
Thanks a lot guys! Commented on the PR #5206. |
Also should get this once it's merged. A number of people have run into it including myself: |
Thanks @jsierles, added. |
Thanks @skevy! Commented on the PR, thanks for the fix! |
This would be awesome too. |
^ yes please |
The Android Picker (1843709) is not 100% ready yet, we want to clean up the API to make it more consistent with iOS. |
Releasing now. I haven't been able to cherry-pick the fix for The Android |
Closing as 0.18 is already released. |
Moving the release to Monday Jan 18 as there are quite a few things to get in plus we had an internal hackathon today on RN + Buck.
alert()
1dc56a6The text was updated successfully, but these errors were encountered: