Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Networking.md #12973

Closed
wants to merge 1 commit into from
Closed

Update Networking.md #12973

wants to merge 1 commit into from
+2 −0

Conversation

ohwhen
Copy link

@ohwhen ohwhen commented Mar 16, 2017 •
edited
Loading

@ohwhen
Update Networking.md
015ad3a 
I ran into an `undefined is not a constructor` when I tried initiating a WebSocket connection. I imported the WebSocket module like so:`import { WebSocket } from 'react-native'`. 

When I changed it to `import { WebSocketModule } from 'react-native'` it worked. So I see two possible solutions:

1. renaming the `WebSocketModule` to `WebSocket`
2. updating the docs

This PR is for facebook#2.
@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 16, 2017
@ohwhen ohwhen closed this Mar 16, 2017
@ohwhen ohwhen deleted the patch-1 branch March 16, 2017 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohwhen @facebook-github-bot