Upgrade to soloader 0.5.1

[gengjiawen]

Motivation

Upgrade to soloader 0.5.1. Fixes #20323.

Test Plan

pass all current ci.

Related PRs

none

Release Notes

[GENERAL] [BUGFIX] [ANDROID] - Upgrade to soloader 0.5.1

[gengjiawen]

@hramos

[gengjiawen]

Looks like 0.5.1 has some problem, see facebook/SoLoader#10.

[passy]

Can you post the error you're seeing? Again, SoLoader in isolation is fine. It's mixing with other dependencies is fine. Can you check with ./gradle :<target>:dependencies that there is no transitive dependency on a prior version?

[gengjiawen]

I post it in this issue facebook/SoLoader#10.
See full log: https://circleci.com/gh/gengjiawen/react-native/676?utm_campaign=build-failed&utm_medium=email&utm_source=notification.

Warning: com.facebook.imagepipeline.nativecode.ImagePipelineNativeLoader: can't find referenced method 'void loadLibrary(java.lang.String)' in program class com.facebook.soloader.SoLoader

[gengjiawen]

Do you think it's a issue in fresco. They need a new release after bump soloader version.

[passy]

They bumped the SoLoader version a while ago, but I don't know if they've released a new version since.

On Sat, 21 Jul 2018, 11:08 Jiawen Geng, ***@***.***> wrote: Do you think it's a issue in fresco. They need a new release after bump soloader version. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#20325 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAmsh4ne6QqrSxtvbhGVGDQCAW1V6Xaks5uIv2ygaJpZM4VZY5D> .

-- timezone: eu/london | utc+1 @passy

[gengjiawen]

@oprisnik we may need a new fresco release, can you help on this, thanks.

[passy]

@gengjiawen Fresco 1.10.0 is already depending on SoLoader 0.5.0, so this isn't the cause: https://mvnrepository.com/artifact/com.facebook.fresco/fresco/1.10.0

[gengjiawen]

But gradle will only use the high version if there are two versions in deps. But let's wait fresco release a new version.

[passy]

@gengjiawen I don't follow. Fresco is using the right version.

[gengjiawen]

So you are saying 0.5.0 is clean version ?

[passy]

I don't think there's a "dirty" version. :D But 0.5.0 is the version that introduced the breaking change, so all dependencies need to be either < 0.5.0 or >= 0.5.0.

[passy]

To reiterate: Upgrading Fresco to the already released 1.10.0 should take care of the issue unless there's another dependency that was built against an old version.

[gengjiawen]

@passy If that's the case. 0.5.1 has bug, the proof is pretty clear.

[passy]

Why?

[gengjiawen]

Are you an android developer ? I think the build log is pretty clear.

[passy]

@gengjiawen That's not a very helpful comment. I'm asking why you insist that SoLoader is broken while everything is pointing to the old version of Fresco which is still in the manifest being responsible for the breakage.

[gengjiawen]

@passy I see your point, let's try new fresco version and see what happens.

[gengjiawen]

@passy The build passed. It seems it's fresco issue. The comment I meant is that from proguard it's definitely soloader issue. I thought maybe you not an android developer so you missed the part. Sorry if you feel offended.

[gengjiawen]

@hramos I think this can be merged.

[passy]

I think it would be good to have the buck dependencies updated in the same commit to prevent them from diverging.

[gengjiawen]

@passy Add buck will be good. But I am not familiar with buck. And also we have fix the issue.
So maybe deal with later or can you help on this ?

[passy]

I could have with that tomorrow. I'll leave it to the maintainers if they want to wait with merging till then.

[gengjiawen]

Glad to hear that.

[passy]

Added a commit to update the Buck targets.

[gengjiawen]

looks like it broken android build.

[gengjiawen]

I see, the master branch commit cause this problem, then we are fine.

[dulmandakh]

@gengjiawen Android CI is green again, please rebase

[facebook-github-bot]

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[gengjiawen]

@dulmandakh Any special reason you want to bump findbugs version ?

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[dulmandakh]

I'm trying to bump testing tools to have best and new features. jsr bumped as a part of mockito version bump in separate PR.

[gengjiawen]

looks like this cause import failed. And this could be done via new pr. Not mixing with this one.

[dulmandakh]

@gengjiawen maybe you should wait, because failure was caused by conflict with previously merged PRs.

@facebook-github-bot shipit

[facebook-github-bot]

dulmandakh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was closed by @gengjiawen in b6f2aad.

Once this commit is added to a release, you will see the corresponding version tag below the description at b6f2aad. If the commit has a single master tag, it is not yet part of a release.