Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: Extension should start/stop recording scheduling profiler data #22015

Closed
bvaughn opened this issue Aug 3, 2021 · 3 comments
Closed

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Aug 3, 2021

Wire up the Profiler's start/stop record button for the new scheduling profiler (#21866).

See this POC by @taneliang as a reference / starting point.

Note that we should probably not add "debugger" as a permission in the extension manifest, but as an optional_permissions that we request at runtime if someone tries to use the new profiler functionality.

@NishantChandla
Copy link

@bvaughn Can I take up this issue? Also, I am new here can you guide me how can I go about solving this. Thanks!

@bvaughn
Copy link
Contributor Author

bvaughn commented Aug 5, 2021

@NishantChandla You're welcome to work on this task if it interests you, but it would have to be an unguided effort. (I don't have bandwidth to guide anyone through it beyond what the description already states.)

This guide may help you get started:
https://github.com/facebook/react/blob/main/packages/react-devtools/CONTRIBUTING.md

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 11, 2021

This is not possible without adding a really pervasive permission, so see #22529 for an alternative.

@bvaughn bvaughn closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants